[cli] Refactor setup - #4597
Merged
Merged
Conversation
bharatkashyap
added
the
create-toolpad-app
Netlify deploy preview |
Janpot
reviewed
Jan 20, 2025
| // eslint-disable-next-line no-console | ||
| console.log(); | ||
|
|
||
| const pkg = await findCtaPackageJson(); |
Member
There was a problem hiding this comment.
Better to remove this call and pass the version as an option.
Collaborator
Author
There was a problem hiding this comment.
If we remove the call, how would we set the default value of the version in case nothing is passed in the version option?
Member
There was a problem hiding this comment.
If there is no sensible default, then you make the option mandatory
Janpot
reviewed
Jan 20, 2025
| return 'pnpm'; | ||
| } | ||
|
|
||
| export async function findCtaPackageJson() { |
Member
There was a problem hiding this comment.
There exist package json types in this workspace already. Should add a return type here.
Janpot
approved these changes
Jan 20, 2025
Janpot
left a comment
Janpot
left a comment
Member
There was a problem hiding this comment.
Few small suggestions. Otherwise seems to be good. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
indexcode into separate files--example