[examples] [docs] Add Vite example with Firebase auth - #4500
Conversation
bharatkashyap
added
docs
|
What's special about the themed example that we need it in more than one runtime? sure it doesn't do anything runtime specific, right? Also feels to me like a vite+firebase example should stand on its own. Adding other concepts in there would make it a bit confusing I think. |
Fair enough, I can remove the theme and custom components from this example and make it focus on the Vite + Firebase integration |
bharatkashyap
changed the title
apedroferreira
left a comment
apedroferreira
left a comment
There was a problem hiding this comment.
Nice, just some small things!
| const lightTheme = createTheme(getMPTheme('light')); | ||
| const darkTheme = createTheme(getMPTheme('dark')); | ||
|
|
||
| const theme = { |
There was a problem hiding this comment.
Can't we use a CSS variables theme instead? Also I can't find this getMPTheme, is this outdated?
There was a problem hiding this comment.
Yes, missed deleting this file (isn't used anywhere anymore)
|
Oh i guess the screenshots are outdated also if we're not using that theme after all. |
Co-authored-by: Pedro Ferreira <10789765+apedroferreira@users.noreply.github.com> Signed-off-by: Bharat Kashyap <bharatkashyap@outlook.com>
Signed-off-by: Bharat Kashyap <bharatkashyap@outlook.com> Co-authored-by: Pedro Ferreira <10789765+apedroferreira@users.noreply.github.com>
3 participants
Uh oh!
There was an error while loading. Please reload this page.