Skip to content

[SignInPage] Remove docs context from component logic #4489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bharatkashyap merged 8 commits into from
Dec 6, 2024
Merged

[SignInPage] Remove docs context from component logic #4489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
26973ca
fix: Remove `docs` context from component logic
bharatkashyap Nov 28, 2024
3ce00af
Merge branch 'master' into core/remove-docs-context
bharatkashyap Dec 5, 2024
5cf87cc
fix: Missed
bharatkashyap Dec 5, 2024
7cb441a
fix: Missed
bharatkashyap Dec 5, 2024
026655c
Merge branches 'core/remove-docs-context' and 'core/remove-docs-conte…
bharatkashyap Dec 5, 2024
ed8e756
fix: CI
bharatkashyap Dec 5, 2024
e938517
fix: Marija review
bharatkashyap Dec 5, 2024
2e13c64
Merge branch 'master' of github.com:mui/mui-toolpad into core/remove-…
bharatkashyap Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion docs/data/toolpad/core/components/sign-in-page/BrandingSignInPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@ export default function BrandingSignInPage() {
return (
// preview-start
<AppProvider branding={BRANDING} theme={theme}>
<SignInPage signIn={signIn} providers={providers} />
<SignInPage
signIn={signIn}
providers={providers}
slotProps={{ emailField: { autoFocus: false } }}
/>
</AppProvider>
// preview-end
);
Expand Down
6 changes: 5 additions & 1 deletion docs/data/toolpad/core/components/sign-in-page/BrandingSignInPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@ export default function BrandingSignInPage() {
return (
// preview-start
<AppProvider branding={BRANDING} theme={theme}>
<SignInPage signIn={signIn} providers={providers} />
<SignInPage
signIn={signIn}
providers={providers}
slotProps={{ emailField: { autoFocus: false } }}
/>
</AppProvider>
// preview-end
);
Expand Down
6 changes: 5 additions & 1 deletion docs/data/toolpad/core/components/sign-in-page/BrandingSignInPage.tsx.preview
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,9 @@ const BRANDING = {
// ...

<AppProvider branding={BRANDING} theme={theme}>
<SignInPage signIn={signIn} providers={providers} />
<SignInPage
signIn={signIn}
providers={providers}
slotProps={{ emailField: { autoFocus: false } }}
/>
</AppProvider>
6 changes: 5 additions & 1 deletion docs/data/toolpad/core/components/sign-in-page/CredentialsSignInPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ export default function CredentialsSignInPage() {
return (
// preview-start
<AppProvider theme={theme}>
<SignInPage signIn={signIn} providers={providers} />
<SignInPage
signIn={signIn}
providers={providers}
slotProps={{ emailField: { autoFocus: false } }}
/>
</AppProvider>
// preview-end
);
Expand Down
6 changes: 5 additions & 1 deletion docs/data/toolpad/core/components/sign-in-page/CredentialsSignInPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@ export default function CredentialsSignInPage() {
return (
// preview-start
<AppProvider theme={theme}>
<SignInPage signIn={signIn} providers={providers} />
<SignInPage
signIn={signIn}
providers={providers}
slotProps={{ emailField: { autoFocus: false } }}
/>
</AppProvider>
// preview-end
);
Expand Down
6 changes: 5 additions & 1 deletion docs/data/toolpad/core/components/sign-in-page/CredentialsSignInPage.tsx.preview
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,9 @@ const providers = [{ id: 'credentials', name: 'Email and Password' }];
// ...

<AppProvider theme={theme}>
<SignInPage signIn={signIn} providers={providers} />
<SignInPage
signIn={signIn}
providers={providers}
slotProps={{ emailField: { autoFocus: false } }}
/>
</AppProvider>
6 changes: 5 additions & 1 deletion docs/data/toolpad/core/components/sign-in-page/MagicLinkAlertSignInPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ export default function MagicLinkAlertSignInPage() {
return (
// preview-start
<AppProvider theme={theme}>
<SignInPage signIn={signIn} providers={providers} />
<SignInPage
signIn={signIn}
providers={providers}
slotProps={{ emailField: { autoFocus: false } }}
/>
</AppProvider>
// preview-end
);
Expand Down
6 changes: 5 additions & 1 deletion docs/data/toolpad/core/components/sign-in-page/MagicLinkAlertSignInPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,11 @@ export default function MagicLinkAlertSignInPage() {
return (
// preview-start
<AppProvider theme={theme}>
<SignInPage signIn={signIn} providers={providers} />
<SignInPage
signIn={signIn}
providers={providers}
slotProps={{ emailField: { autoFocus: false } }}
/>
</AppProvider>
// preview-end
);
Expand Down
6 changes: 5 additions & 1 deletion docs/data/toolpad/core/components/sign-in-page/MagicLinkAlertSignInPage.tsx.preview
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,9 @@ resolve({
// ...

<AppProvider theme={theme}>
<SignInPage signIn={signIn} providers={providers} />
<SignInPage
signIn={signIn}
providers={providers}
slotProps={{ emailField: { autoFocus: false } }}
/>
</AppProvider>
30 changes: 0 additions & 30 deletions docs/data/toolpad/core/components/sign-in-page/MagicLinkSignInPage.js
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions docs/data/toolpad/core/components/sign-in-page/MagicLinkSignInPage.tsx
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions docs/data/toolpad/core/components/sign-in-page/MagicLinkSignInPage.tsx.preview
View file
Open in desktop

This file was deleted.

6 changes: 5 additions & 1 deletion docs/data/toolpad/core/components/sign-in-page/NotificationsSignInPageError.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@ export default function NotificationsSignInPageError() {
return (
// preview-start
<AppProvider theme={theme}>
<SignInPage signIn={signIn} providers={providers} />
<SignInPage
signIn={signIn}
providers={providers}
slotProps={{ emailField: { autoFocus: false } }}
/>
</AppProvider>
// preview-end
);
Expand Down
6 changes: 5 additions & 1 deletion docs/data/toolpad/core/components/sign-in-page/NotificationsSignInPageError.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,11 @@ export default function NotificationsSignInPageError() {
return (
// preview-start
<AppProvider theme={theme}>
<SignInPage signIn={signIn} providers={providers} />
<SignInPage
signIn={signIn}
providers={providers}
slotProps={{ emailField: { autoFocus: false } }}
/>
</AppProvider>
// preview-end
);
Expand Down
6 changes: 5 additions & 1 deletion docs/data/toolpad/core/components/sign-in-page/NotificationsSignInPageError.tsx.preview
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,9 @@ resolve({
// ...

<AppProvider theme={theme}>
<SignInPage signIn={signIn} providers={providers} />
<SignInPage
signIn={signIn}
providers={providers}
slotProps={{ emailField: { autoFocus: false } }}
/>
</AppProvider>
4 changes: 3 additions & 1 deletion docs/data/toolpad/core/components/sign-in-page/OAuthSignInPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,14 @@ const providers = [
// preview-end

const signIn = async (provider) => {
// preview-start
const promise = new Promise((resolve) => {
setTimeout(() => {
console.log(`Sign in with ${provider.id}`);
resolve();
resolve({ error: 'This is a fake error' });
}, 500);
});
// preview-end
return promise;
};

Expand Down
16 changes: 12 additions & 4 deletions docs/data/toolpad/core/components/sign-in-page/OAuthSignInPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import * as React from 'react';
import { AppProvider } from '@toolpad/core/AppProvider';
import { SignInPage, type AuthProvider } from '@toolpad/core/SignInPage';
import {
AuthResponse,
SignInPage,
type AuthProvider,
} from '@toolpad/core/SignInPage';
import { useTheme } from '@mui/material/styles';

// preview-start
Expand All @@ -13,13 +17,17 @@ const providers = [
];
// preview-end

const signIn: (provider: AuthProvider) => void = async (provider) => {
const promise = new Promise<void>((resolve) => {
const signIn: (provider: AuthProvider) => void | Promise<AuthResponse> = async (
provider,
) => {
// preview-start
const promise = new Promise<AuthResponse>((resolve) => {
setTimeout(() => {
console.log(`Sign in with ${provider.id}`);
resolve();
resolve({ error: 'This is a fake error' });
}, 500);
});
// preview-end
return promise;
};

Expand Down
9 changes: 9 additions & 0 deletions docs/data/toolpad/core/components/sign-in-page/OAuthSignInPage.tsx.preview
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,15 @@ const providers = [

// ...

const promise = new Promise<AuthResponse>((resolve) => {
setTimeout(() => {
console.log(`Sign in with ${provider.id}`);
resolve({ error: 'This is a fake error' });
}, 500);
});

// ...

<AppProvider theme={theme}>
<SignInPage signIn={signIn} providers={providers} />
</AppProvider>
6 changes: 5 additions & 1 deletion docs/data/toolpad/core/components/sign-in-page/PasskeySignInPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ export default function PasskeySignInPage() {
return (
// preview-start
<AppProvider theme={theme}>
<SignInPage signIn={signIn} providers={providers} />
<SignInPage
signIn={signIn}
providers={providers}
slotProps={{ emailField: { autoFocus: false } }}
/>
</AppProvider>
// preview-end
);
Expand Down
6 changes: 5 additions & 1 deletion docs/data/toolpad/core/components/sign-in-page/PasskeySignInPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ export default function PasskeySignInPage() {
return (
// preview-start
<AppProvider theme={theme}>
<SignInPage signIn={signIn} providers={providers} />
<SignInPage
signIn={signIn}
providers={providers}
slotProps={{ emailField: { autoFocus: false } }}
/>
</AppProvider>
// preview-end
);
Expand Down
6 changes: 5 additions & 1 deletion docs/data/toolpad/core/components/sign-in-page/PasskeySignInPage.tsx.preview
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,9 @@ const providers = [{ id: 'passkey', name: 'Passkey' }];
// ...

<AppProvider theme={theme}>
<SignInPage signIn={signIn} providers={providers} />
<SignInPage
signIn={signIn}
providers={providers}
slotProps={{ emailField: { autoFocus: false } }}
/>
</AppProvider>
2 changes: 1 addition & 1 deletion docs/data/toolpad/core/components/sign-in-page/SlotPropsSignIn.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default function SlotPropsSignIn() {
)
}
slotProps={{
emailField: { variant: 'standard' },
emailField: { variant: 'standard', autoFocus: false },
passwordField: { variant: 'standard' },
submitButton: { variant: 'outlined' },
rememberMe: {
Expand Down
2 changes: 1 addition & 1 deletion docs/data/toolpad/core/components/sign-in-page/SlotPropsSignIn.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default function SlotPropsSignIn() {
)
}
slotProps={{
emailField: { variant: 'standard' },
emailField: { variant: 'standard', autoFocus: false },
passwordField: { variant: 'standard' },
submitButton: { variant: 'outlined' },
rememberMe: {
Expand Down
2 changes: 1 addition & 1 deletion docs/data/toolpad/core/components/sign-in-page/ThemeSignInPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const signIn = async (provider) => {
const promise = new Promise((resolve) => {
setTimeout(() => {
console.log(`Sign in with ${provider.id}`);
resolve();
resolve({ error: 'This is a mock error message.' });
}, 500);
});
return promise;
Expand Down
14 changes: 10 additions & 4 deletions docs/data/toolpad/core/components/sign-in-page/ThemeSignInPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import * as React from 'react';
import { AppProvider } from '@toolpad/core/AppProvider';
import { SignInPage, type AuthProvider } from '@toolpad/core/SignInPage';
import {
SignInPage,
type AuthProvider,
type AuthResponse,
} from '@toolpad/core/SignInPage';
import { createTheme } from '@mui/material/styles';
import { useColorSchemeShim } from 'docs/src/modules/components/ThemeContext';
import { getDesignTokens, inputsCustomizations } from './customTheme';
Expand All @@ -11,11 +15,13 @@ const providers = [
{ id: 'credentials', name: 'Email and Password' },
];

const signIn: (provider: AuthProvider) => void = async (provider) => {
const promise = new Promise<void>((resolve) => {
const signIn: (provider: AuthProvider) => void | Promise<AuthResponse> = async (
provider,
) => {
const promise = new Promise<AuthResponse>((resolve) => {
setTimeout(() => {
console.log(`Sign in with ${provider.id}`);
resolve();
resolve({ error: 'This is a mock error message.' });
}, 500);
});
return promise;
Expand Down
Loading