[DashboardLayout] Add width containment on flex container - #4414
Merged
bharatkashyap merged 5 commits intoNov 19, 2024
Conversation
ydainna
approved these changes
Nov 14, 2024
Member
|
why max width? shouldn't the container just be the width of the available space, regardless of the content? |
Collaborator
Author
You're right, the fix works because of the Screen.Recording.2024-11-18.at.8.33.46.PM.mov |
apedroferreira
approved these changes
Nov 18, 2024
apedroferreira
left a comment
apedroferreira
left a comment
Collaborator
There was a problem hiding this comment.
This seems to do it. Thanks a lot, Bharat!
|
Glad you guys figured it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes [example][pageContainer] Unable to scroll a Datagrid #4407
Closes Responsive bug with MUI component #4387
Adds a
{ position: relative, maxWidth: 100% }to the flex container insideDashboardLayoutto add max-width containment and enable the children to scrollStackBlitz showing corrected behaviour https://stackblitz.com/edit/vitejs-vite-vk9u7p