[autocomplete] Fix label shrink issue when renderValue is used with empty array in multiple mode - #46047
Merged
ZeeshanTamboli merged 4 commits intoMay 20, 2025
Conversation
…n multiple mode using renderValue
ZeeshanTamboli
added
type: bug
Netlify deploy previewhttps://deploy-preview-46047--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
Member
Author
|
Can this be reviewed? I'd like to have it included in the upcoming release since it's a regression. |
Member
Author
|
Any review on this? |
sai6855
approved these changes
May 20, 2025
DiegoAndai
reviewed
May 20, 2025
DiegoAndai
left a comment
DiegoAndai
left a comment
Member
There was a problem hiding this comment.
Sorry for the delay in the review @ZeeshanTamboli, I was on vacation. I'm back now.
oliviertassinari
changed the title
renderValue is used with empty array in multiple moderenderValue is used with empty array in multiple mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46037
Regression from #45387
We didn’t skip rendering
startAdornment, which caused the label to shrink whenvalueis empty inmultiplemode with a customrenderValue.Before: https://codesandbox.io/p/sandbox/stupefied-snowflake-wsw376
After: https://codesandbox.io/p/devbox/hidden-haze-f3rzz7