Skip to content

[internal] Update @testing-library/react and @testing-library/dom packages#42349

Merged
ZeeshanTamboli merged 3 commits intomui:nextfrom
ZeeshanTamboli:update-@testing-library-packages
May 23, 2024
Merged

[internal] Update @testing-library/react and @testing-library/dom packages#42349
ZeeshanTamboli merged 3 commits intomui:nextfrom
ZeeshanTamboli:update-@testing-library-packages

Conversation

@ZeeshanTamboli
Copy link
Copy Markdown
Member

@ZeeshanTamboli ZeeshanTamboli commented May 23, 2024

Closes #41989
Closes #42296

The latest versions of @testing-library/user-event and @testing-library/react depend on @testing-library/dom v10, causing unit test failures. Bumping them together works. See #41989 (comment).

Also, see this pain point.

Should we group @testing-library/* packages in the renovate config?

@ZeeshanTamboli ZeeshanTamboli added dependencies Update of dependencies. internal Behind-the-scenes enhancement. Formerly called “core”. labels May 23, 2024
@mui-bot
Copy link
Copy Markdown

mui-bot commented May 23, 2024

Netlify deploy preview

https://deploy-preview-42349--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against f22363b

@ZeeshanTamboli ZeeshanTamboli changed the title Bump @testing-library/react and @testing-library/dom packages [core] Bump @testing-library/react and @testing-library/dom packages May 23, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [core] Bump @testing-library/react and @testing-library/dom packages [core] Update @testing-library/react and @testing-library/dom packages May 23, 2024
@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review May 23, 2024 07:43
@ZeeshanTamboli ZeeshanTamboli requested a review from a team May 23, 2024 07:44
@Janpot
Copy link
Copy Markdown
Member

Janpot commented May 23, 2024

The latest versions of @testing-library/user-event and @testing-library/react depend on @testing-library/dom v10, causing unit test failures. Bumping them together works. See #41989 (comment).

We should group @testing-library/* in renovate.json.

@ZeeshanTamboli
Copy link
Copy Markdown
Member Author

The latest versions of @testing-library/user-event and @testing-library/react depend on @testing-library/dom v10, causing unit test failures. Bumping them together works. See #41989 (comment).

We should group @testing-library/* in renovate.json.

@Janpot Done.

@ZeeshanTamboli ZeeshanTamboli merged commit 7aeccb5 into mui:next May 23, 2024
@ZeeshanTamboli ZeeshanTamboli deleted the update-@testing-library-packages branch May 23, 2024 11:06
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
@oliviertassinari oliviertassinari changed the title [core] Update @testing-library/react and @testing-library/dom packages [internal] Update @testing-library/react and @testing-library/dom packages Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Update of dependencies. internal Behind-the-scenes enhancement. Formerly called “core”.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants