Skip to content

[test] Stabilize Combobox and Menu test timing - #5470

Merged
atomiks merged 1 commit into
mui:masterfrom
atomiks:codex/stabilize-combobox-reopen-tests
Aug 12, 2026
Merged

atomiks merged 1 commit into
mui:masterfrom
atomiks:codex/stabilize-combobox-reopen-tests

Conversation

@atomiks

@atomiks atomiks commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

PR #5362 added close-animation coverage that could assert before the reopened Combobox input cleanup committed under full browser-suite load. Two Menu indicator tests could also finish while an open-state animation frame was still pending, producing React act warnings.\n\n## Changes\n\n- Wait for the observable Combobox input and option state in the affected reopen paths instead of relying on one microtask or a nearby DOM signal.\n- Capture and flush the Menu open-state animation-frame queue inside act before testing synchronous no-animation indicator removal.\n\nThe final close-animation set passed 20 consecutive runs, both complete Menu indicator files passed 10 consecutive runs, and the full Chromium project passed three consecutive runs with 8,648 tests per run.

@atomiks atomiks added the component: menu Changes related to the menu component. label Aug 12, 2026
@atomiks
atomiks requested a review from colmtuite as a code owner August 12, 2026 07:49
@atomiks atomiks added type: bug It doesn't behave as expected. test component: combobox Changes related to the combobox component. labels Aug 12, 2026
@atomiks atomiks added component: menu Changes related to the menu component. type: bug It doesn't behave as expected. test component: combobox Changes related to the combobox component. labels Aug 12, 2026
@pkg-pr-new

pkg-pr-new Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

commit: efaf978

@code-infra-dashboard

code-infra-dashboard Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

Bundle size

Bundle Parsed size Gzip size
@base-ui/react 0B(0.00%) 0B(0.00%)

Details of bundle changes

Performance

Total duration: 1,070.13 ms +38.06 ms(+3.7%) | Renders: 76 (+0) | Paint: 1,675.33 ms +66.19 ms(+4.1%)

Test Duration Renders
Tooltip mount (300 contained roots) 64.47 ms 🔺+20.63 ms(+47.1%) 1 (+0)
Combobox type — 500 items, all stay mounted (type "Row ") 34.43 ms 🔺+7.07 ms(+25.8%) 11 (+0)
Combobox open — 500 items 39.70 ms +6.61 ms(+20.0%) 4 (+0)

12 tests within noise — details

Metric alarms

Test Metric Change
Tooltip mount (300 contained roots) bench:paint 🔺 +33.49 ms
Combobox type — 500 items, all stay mounted (type "Row ") bench:paint#combobox-open 🔺 +15.03 ms
Combobox type — 500 items, all stay mounted (type "Row ") bench:paint 🔺 +15.03 ms
Combobox open — 500 items bench:paint#combobox-open 🔺 +13.11 ms
Combobox open — 500 items bench:paint 🔺 +13.11 ms

Check out the code infra dashboard for more information about this PR.

@netlify

netlify Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit efaf978
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6a7c27c392412a00080380af
😎 Deploy Preview https://deploy-preview-5470--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks
atomiks force-pushed the codex/stabilize-combobox-reopen-tests branch from a740a63 to efaf978 Compare August 12, 2026 07:58
@atomiks
atomiks merged commit e26f7f3 into mui:master Aug 12, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: combobox Changes related to the combobox component. component: menu Changes related to the menu component. test type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant