Repository navigation
[test] Stabilize Combobox and Menu test timing - #5470
Merged
atomiks merged 1 commit intoAug 12, 2026
Merged
Conversation
atomiks
requested review from
flaviendelangle,
jjenzz and
michaldudak
as code owners
August 12, 2026 07:49
commit: |
Bundle size
PerformanceTotal duration: 1,070.13 ms +38.06 ms(+3.7%) | Renders: 76 (+0) | Paint: 1,675.33 ms +66.19 ms(+4.1%)
12 tests within noise — details Metric alarms
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
force-pushed
the
codex/stabilize-combobox-reopen-tests
branch
from
August 12, 2026 07:58
a740a63 to
efaf978
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #5362 added close-animation coverage that could assert before the reopened Combobox input cleanup committed under full browser-suite load. Two Menu indicator tests could also finish while an open-state animation frame was still pending, producing React act warnings.\n\n## Changes\n\n- Wait for the observable Combobox input and option state in the affected reopen paths instead of relying on one microtask or a nearby DOM signal.\n- Capture and flush the Menu open-state animation-frame queue inside act before testing synchronous no-animation indicator removal.\n\nThe final close-animation set passed 20 consecutive runs, both complete Menu indicator files passed 10 consecutive runs, and the full Chromium project passed three consecutive runs with 8,648 tests per run.