Repository navigation
Conversation
commit: |
Bundle size
PerformanceTotal duration: 1,149.69 ms -80.11 ms(-6.5%) | Renders: 78 (+0) | Paint: 1,810.74 ms -146.88 ms(-7.5%) No significant changes — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
9413b22 to
ddf6e51
Compare
|
Note Superseded by #5362, which releases the frozen close query inline in One narrow gap remains: a controlled |
When a popup with an exit animation closes with a typed query, the query is frozen in
closeQueryso the filtered list stays stable during the exit. If the popup is reopened before the exit completes,handleUnmountnever runs, and the cleanup insetOpenwas gated oninputInsidePopup— so a standard combobox (input outside the popup) reopened with the stale frozen query. Typing to reopen filtered the list by the previous query instead of the live input value until the next keystroke released it (and on 1.6.0, which lacks the in-open release from #5266, the stale filter persists for the entire reopened session).The fix clears
closeQueryon any reopen insetOpen, keeping the input-inside-popup-specific cleanup (resettingqueryChangedAfterOpenand the deferred input clear) inside its original gate so that behavior is unchanged.Adds a Chromium regression test: type a query, close via Enter with no highlighted item, type again during the close animation, and assert the reopened list is filtered by the live input value. The bug has existed since the component was introduced, affecting both single and multiple selection modes with the input outside the popup.