Skip to content

[form] Fix validation bugs - #4894

Merged
atomiks merged 2 commits into
mui:masterfrom
atomiks:codex/form-bugs
May 28, 2026
Merged

atomiks merged 2 commits into
mui:masterfrom
atomiks:codex/form-bugs

Conversation

@atomiks

@atomiks atomiks commented May 22, 2026 •

Copy link
Copy Markdown
Contributor

This fixes a small batch of Form bugs found during review.

Changes

  • Allow submit to continue when async field validation is still pending unless a field is already explicitly invalid.
  • Make Form docs snippets safer by JSON-stringifying fetch bodies and null-checking actionsRef examples.

Original findings addressed

  • [P2] Async validators could block the first valid submit.
  • [P3] Public docs examples had copy-paste issues.

@atomiks atomiks added type: bug It doesn't behave as expected. component: form Changes related to the form component. component: field Changes related to the field component. docs Improvements or additions to the documentation. labels May 22, 2026 — with ChatGPT Codex Connector
@pkg-pr-new

pkg-pr-new Bot commented May 22, 2026 •

Copy link
Copy Markdown

commit: c377cc6

@code-infra-dashboard

code-infra-dashboard Bot commented May 22, 2026 •

Copy link
Copy Markdown

Bundle size

Bundle Parsed size Gzip size
@base-ui/react ▼-8B(0.00%) ▼-7B(0.00%)

Details of bundle changes

Performance

Total duration: 1,364.92 ms +199.61 ms(+17.1%) | Renders: 50 (+0) | Paint: 2,057.27 ms +307.90 ms(+17.6%)

Test Duration Renders
Tabs mount (200 instances) 271.23 ms 🔺+58.60 ms(+27.6%) 4 (+0)
Slider mount (300 instances) 191.77 ms 🔺+35.78 ms(+22.9%) 3 (+0)
Tooltip mount (300 contained roots) 73.14 ms 🔺+31.11 ms(+74.0%) 1 (+0)
Dialog mount (300 instances) 61.15 ms 🔺+11.42 ms(+23.0%) 1 (+0)

8 tests within noise — details


Check out the code infra dashboard for more information about this PR.

@netlify

netlify Bot commented May 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit c377cc6
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6a17fb05dd3371000888628c
😎 Deploy Preview https://deploy-preview-4894--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label May 27, 2026
@atomiks
atomiks force-pushed the codex/form-bugs branch from 3bfa16b to d1e3d6c Compare May 27, 2026 05:59
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label May 27, 2026
@atomiks
atomiks force-pushed the codex/form-bugs branch 2 times, most recently from 941605d to 3bc2ef3 Compare May 27, 2026 06:51
@atomiks
atomiks force-pushed the codex/form-bugs branch from 3bc2ef3 to acdcadf Compare May 27, 2026 06:59
@atomiks
atomiks marked this pull request as ready for review May 27, 2026 07:04
@atomiks atomiks removed the component: form Changes related to the form component. label May 28, 2026
@atomiks
atomiks merged commit 72b3fa5 into mui:master May 28, 2026
23 checks passed
@atomiks
atomiks deleted the codex/form-bugs branch May 28, 2026 08:47
@michaldudak michaldudak mentioned this pull request Jun 17, 2026
@michaldudak michaldudak removed the docs Improvements or additions to the documentation. label Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: field Changes related to the field component. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants