fix(llama-cpp): Set enable_thinking in the correct place#8973
Merged
mudler merged 1 commit intomudler:masterfrom Mar 12, 2026
Merged
fix(llama-cpp): Set enable_thinking in the correct place#8973mudler merged 1 commit intomudler:masterfrom
mudler merged 1 commit intomudler:masterfrom
Conversation
Signed-off-by: Richard Palethorpe <io@richiejp.com>
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
localai-bot
pushed a commit
to localai-bot/LocalAI
that referenced
this pull request
Mar 18, 2026
Signed-off-by: Richard Palethorpe <io@richiejp.com> Signed-off-by: localai-bot <localai-bot@users.noreply.github.com>
localai-bot
pushed a commit
to localai-bot/LocalAI
that referenced
this pull request
Mar 25, 2026
Signed-off-by: Richard Palethorpe <io@richiejp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows thinking to be properly disabled when using Jinja templates
Notes for Reviewers
We were setting enable_thinking in the wrong map. It should be part of chat_template_kwargs
Signed commits