fix(mcp): drop the duplicated scheduling methods on stubClient - #11323
Merged
Conversation
master does not compile:
vet: core/http/endpoints/mcp/localai_assistant_test.go:157:19:
method stubClient.ListScheduling already declared at
core/http/endpoints/mcp/localai_assistant_test.go:87:19
Two fixes for the same breakage landed. The four Scheduling methods were
already present at lines 87-99, in interface order after ListNodes, by
the time #11318 merged; #11318 appended its own copy after
GetRouterDecisions. The two blocks sit in different parts of the file, so
git merged both without a conflict and nothing flagged it.
Remove the appended copy and keep the one in interface order. Pure
deletion, no behaviour change.
Verified: go vet clean on ./core/http/endpoints/mcp/, and
go test ./core/http/endpoints/mcp/ passes.
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Assisted-by: Claude Code:claude-opus-5 [Read] [Edit] [Bash]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
master does not compile
Reproduced on
bd076376b(current master HEAD).Cause
Two fixes for the same breakage landed. By the time #11318 merged, the four Scheduling methods were already present at lines 87-99, in interface order after
ListNodes. #11318 appended its own copy afterGetRouterDecisionsat lines 157-171.The two blocks are in different parts of the file, so git merged both without a textual conflict and nothing flagged the collision. Duplicate methods on the same type are a compile error, so the package went straight back to not typechecking.
That one is on me: #11318 was opened against a base that had already moved, and I did not re-check before it merged.
Fix
Remove the appended copy, keep the one in interface order. Pure deletion, 16 lines, no behaviour change.
Verification
go vet ./core/http/endpoints/mcp/clean.go test ./core/http/endpoints/mcp/passes.1 file changed, 16 deletions(-)).