Remove dependency of System.Runtime.Serialization.dll#29
Closed
takeshik wants to merge 1 commit intomsgpack:masterfrom
takeshik:feature/remove-datacontract-dependency
Closed
Remove dependency of System.Runtime.Serialization.dll#29takeshik wants to merge 1 commit intomsgpack:masterfrom takeshik:feature/remove-datacontract-dependency
takeshik wants to merge 1 commit intomsgpack:masterfrom
takeshik:feature/remove-datacontract-dependency
Conversation
Remove the references for DataContractAttribute and DataMemberAttribute and re-implement with reflection-based attribute retrieving.
yfakariya
added a commit
that referenced
this pull request
May 24, 2014
Member
|
Thank you! |
yfakariya
added a commit
that referenced
this pull request
May 24, 2014
Signed-off-by: yfakariya <yfakariya@gmail.com>
Contributor
Author
|
I read the fixes and got it. Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
System.Runtime.Serialization.DataContractAttributeandDataMemberAttributewith reflection rather than static member access.0.5.Purpose
System.Runtime.Serializationis only for compatibility for other serializer, but this causes loadingSystem.Runtime.Serializationassembly. I think this is a bit wasteful.Concerns