feat(fastly): Log response Content-Encoding into BigQuery - #487
Open
leplatrem wants to merge 1 commit into
Open
Conversation
Contributor
Release plan
|
alexcottner
approved these changes
Aug 7, 2026
Contributor
|
Hi @leplatrem, thanks for this PR. Adding a column like this will impact the schema of all other Bigquery tables which can cost us a lot in the end. Before introducing this change, we need to rework how I’m going to create a separate ticket to track that work. In the meantime, I think we should put this PR on hold until that change is in place. |
Contributor
|
As a side note, once the larger change is implemented, this PR will also need to edit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Without this, we don't have any way to track which content-encoding ended up being negociated with the client.
In the context of Dictionary Compression Transport, we need to distinguish clients that pull deltas, from gzip, and from raw responses.
Alternative approach was this : https://github.com/mozilla/webservices-infra/pull/12059 but adding this column seems cleaner
Related Tickets & Documents