Skip to content

feat(fastly): Log response Content-Encoding into BigQuery - #487

Open
leplatrem wants to merge 1 commit into
mainfrom
fastly-log-content-encoding
Open

feat(fastly): Log response Content-Encoding into BigQuery#487
leplatrem wants to merge 1 commit into
mainfrom
fastly-log-content-encoding

Conversation

@leplatrem

Copy link
Copy Markdown

Description

Without this, we don't have any way to track which content-encoding ended up being negociated with the client.

In the context of Dictionary Compression Transport, we need to distinguish clients that pull deltas, from gzip, and from raw responses.

Alternative approach was this : https://github.com/mozilla/webservices-infra/pull/12059 but adding this column seems cleaner

Related Tickets & Documents

@leplatrem
leplatrem requested review from a team and Tibap as code owners August 7, 2026 13:56
@leplatrem
leplatrem requested a review from bkochendorfer August 7, 2026 13:56
@github-actions github-actions Bot added the minor This PR will increment a minor version label Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Release plan

Directory Previous version New version
google_fastly_waf 2.28.0 2.29.0

@leplatrem
leplatrem requested a review from alexcottner August 7, 2026 14:22
@Tibap

Tibap commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Hi @leplatrem, thanks for this PR.

Adding a column like this will impact the schema of all other Bigquery tables which can cost us a lot in the end. Before introducing this change, we need to rework how bigquery.tf builds the schema so that columns can be added conditionally. That’s a larger change and goes beyond the scope of this PR.

I’m going to create a separate ticket to track that work. In the meantime, I think we should put this PR on hold until that change is in place.

@Tibap

Tibap commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

As a side note, once the larger change is implemented, this PR will also need to edit bq_format_v2.txt to include this new column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor This PR will increment a minor version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants