Update the signatures-helpers to actually handle MissingDataExceptions - #21652
Merged
timvandermeij merged 3 commits intoJul 28, 2026
Merged
Conversation
The `PDFDocument.prototype.signatures` getter returns a (shadowed) Promise, however the way that it invokes various helper-methods can lead to *intermittent* failures to parse the signature data. These helper-methods will lookup a fair amount of Dictionary data, however any one of those cases could throw `MissingDataException` during document loading. To avoid having to re-factor those methods a lot, and adding a bunch more `pdfManager.ensureDoc()` calls, they are instead made asynchronous and the Dictionary lookups changed to use `Dict.prototype.getAsync` (similar to the existing `fieldObjects` handling). Technically this additional asynchronicity may be ever so slightly slower, however I don't think it matters in practice since: most PDFs don't have any signatures, the signature-UI is initialized lazily in the viewer, and finally fetching/parsing of signatures do not block rendering. Also, note how multiple values are being fetched in parallel in order to attempt to reduce overall asynchronicity. *Note:* The unit-test changes are essentially fixing pre-existing bugs, that this patch exposed, since the test-only `Dict` instances weren't able to fetch indirect objects.
Given that these checks are synchronous, we can avoid a little bit of unnecessary data-fetching if the `ByteRange` is invalid.
…atureDict` method
Snuffleupagus
temporarily deployed
to
code-coverage
July 28, 2026 14:21 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 28, 2026 14:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 28, 2026 14:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 28, 2026 14:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 28, 2026 14:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 28, 2026 14:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 28, 2026 14:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 28, 2026 14:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 28, 2026 14:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 28, 2026 14:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 28, 2026 14:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 28, 2026 14:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 28, 2026 14:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 28, 2026 14:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 28, 2026 14:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 28, 2026 14:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21652 +/- ##
==========================================
- Coverage 89.83% 89.83% -0.01%
==========================================
Files 263 263
Lines 66899 66888 -11
==========================================
- Hits 60100 60086 -14
- Misses 6799 6802 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timvandermeij
approved these changes
Jul 28, 2026
timvandermeij
left a comment
timvandermeij
left a comment
Collaborator
There was a problem hiding this comment.
r=me, with passing browser tests. Thank you for improving this!
Collaborator
|
/botio browsertest |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7e55c3e407e5661/output.txt |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/26d25e84d922709/output.txt |
Collaborator
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7e55c3e407e5661/output.txt Total script time: 17.96 mins
|
Collaborator
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/26d25e84d922709/output.txt Total script time: 23.40 mins
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PDFDocument.prototype.signaturesgetter returns a (shadowed) Promise, however the way that it invokes various helper-methods can lead to intermittent failures to parse the signature data.These helper-methods will lookup a fair amount of Dictionary data, however any one of those cases could throw
MissingDataExceptionduring document loading.To avoid having to re-factor those methods a lot, and adding a bunch more
pdfManager.ensureDoc()calls, they are instead made asynchronous and the Dictionary lookups changed to useDict.prototype.getAsync(similar to the existingfieldObjectshandling).Technically this additional asynchronicity may be ever so slightly slower, however I don't think it matters in practice since: most PDFs don't have any signatures, the signature-UI is initialized lazily in the viewer, and finally fetching/parsing of signatures do not block rendering.
Also, note how multiple values are being fetched in parallel in order to attempt to reduce overall asynchronicity.
Note: The unit-test changes are essentially fixing pre-existing bugs, that this patch exposed, since the test-only
Dictinstances weren't able to fetch indirect objects.