electron and web workers

[cvlmtg]

Hi, we are developing an app which runs in the browser and as an electron app. There's been a release that has introduced this code:

if (typeof module !== 'undefined' && module.require) {
   // node.js - disable worker and set require.ensure.
   PDFJS.disableWorker = true;
   ...

The problem is that module.require exists in electron too, so web workers are disabled even if they should not. I patched pdf.js this way:

if (typeof window === 'undefined' && typeof module !== 'undefined' && module.require) {
   // node.js - disable worker and set require.ensure.
   PDFJS.disableWorker = true;
   ...

and it seems to work. I think this patch should not cause other unwanted troubles, so could it be possibile to add it to pdf.js?

[yurydelendik]

We cannot introduce typeof window === 'undefined' -- the stubs for window object can be added to global. Can we rely on something else, e.g. process?

[cvlmtg]

I think it should be ok, I'll check it tomorrow. I was thinking about __filename too, but it doesn't exists in node repl, just when evaluated in a script.

[cvlmtg]

ok I think this might do:

node

 ~ node
> process.versions.electron
undefined

electron

process.versions.electron
"0.36.5"

I'll do some tests with this code:

if (typeof module !== 'undefined' && module.require && typeof process.versions.electron === 'undefined') {

[Rob--W]

What about ditching duck-typing of the environment and using typeof Worker !== 'function' instead?

[cvlmtg]

I think that should be ok too

[yurydelendik]

Fixed our dependence on stub for worker, so typeof worker === 'undefined' check shall work now. See #7126 and it shall fix this issue.

[cvlmtg]

thanks, we'll try it soon!