Repository navigation
Conversation
Added the metrics_support crate. This makes it easier to add metrics support to a component. Crates don't need to mess around with optional dependencies, feature flags, and build scripts. They just need to add a dependency on metrics_support. Moved `places` and `error-support` to using it. Move logins to recording metrics in Rust using metrics_support. Update function signatures to not return metric data like LoginsDeletionMetrics. Export the `record_key_regeneration_event` function directly from Rust. This is a breaking change for Android since it changes the naming for KeyRegenerationEventReason. I don't think it's a breaking change for iOS, because iOS doesn't seem to use it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the metrics_support crate. This makes it easier to add metrics support to a component. Crates don't need to mess around with optional dependencies, feature flags, and build scripts. They just need to add a dependency on metrics_support. Moved
placesanderror-supportto using it.Move logins to recording metrics in Rust using metrics_support. Update function signatures to not return metric data like LoginsDeletionMetrics. Export the
record_key_regeneration_eventfunction directly from Rust.This is a breaking change for Android since it changes the naming for KeyRegenerationEventReason. I don't think it's a breaking change for iOS, because iOS doesn't seem to use it.
Pull Request checklist
[ci full]to the PR title.