Skip to content

Report account engine choices and declare enabled engines in sync_man… - #7806

Draft
mhammond wants to merge 1 commit into
mozilla:mainfrom
mhammond:push-uwvruxvpnplp
Draft

mhammond wants to merge 1 commit into
mozilla:mainfrom
mhammond:push-uwvruxvpnplp

Conversation

@mhammond

Copy link
Copy Markdown
Member

…ager

SyncResult.account_engine_choices reports meta/global's engines and declined, including a meta/global written by this sync, so apps using per-device engine choices can adopt them.

SyncParams.enabled_engines declares all the engines a device has chosen to sync, replacing DeviceSettings.enabled_engines. It doesn't decide what's synced, except that SyncEngineSelection::All means those engines.

sync-test checks the reported choices with either model and after a fresh start, and that enabled_engines is what SyncEngineSelection::All syncs.

This should get us very close to having Fenix be capable of using this model.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

…ager

SyncResult.account_engine_choices reports meta/global's engines and declined,
including a meta/global written by this sync, so apps using per-device engine
choices can adopt them.

SyncParams.enabled_engines declares all the engines a device has chosen to
sync, replacing DeviceSettings.enabled_engines. It doesn't decide what's
synced, except that SyncEngineSelection::All means those engines.

sync-test checks the reported choices with either model and after a fresh
start, and that enabled_engines is what SyncEngineSelection::All syncs.
@mhammond

Copy link
Copy Markdown
Member Author

(not ready to land, but ready for feedback :)

@mhammond
mhammond marked this pull request as draft November 19, 2026 11:00
@lougeniaC64

Copy link
Copy Markdown
Contributor

This should get us very close to having Fenix be capable of using this model.

Is this different than iOS? Where there obstacles on Fenix that don't exist on iOS?

@lougeniaC64

lougeniaC64 commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Also, and I might be missing some context, but is this in support of the CWTS work? Spoke to Mark about this and, with the added context, these changes make sense to me at least initially. Will probably need to think of a few test cases to catch any edge cases but otherwise looks good.

@mhammond

Copy link
Copy Markdown
Member Author

This should get us very close to having Fenix be capable of using this model.

Is this different than iOS? Where there obstacles on Fenix that don't exist on iOS?

No, iOS will need this too I believe. Most of this is about the complexity inherent in the fact that a first sync needs to adopt account choices, and later it needs to be able to restore the per-account setting even if the local device now has different once (and I don't think this PR goes all the way for that one). It should work well with CWTS as it will be fine if the engine choices are known before that first sync.

@lougeniaC64

Copy link
Copy Markdown
Contributor

No, iOS will need this too I believe.

Okay, just checking. I was just wondering while Fenix was called out but the above explanation make sense.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants