Repository navigation
Conversation
…ager SyncResult.account_engine_choices reports meta/global's engines and declined, including a meta/global written by this sync, so apps using per-device engine choices can adopt them. SyncParams.enabled_engines declares all the engines a device has chosen to sync, replacing DeviceSettings.enabled_engines. It doesn't decide what's synced, except that SyncEngineSelection::All means those engines. sync-test checks the reported choices with either model and after a fresh start, and that enabled_engines is what SyncEngineSelection::All syncs.
|
(not ready to land, but ready for feedback :) |
Is this different than iOS? Where there obstacles on Fenix that don't exist on iOS? |
|
|
No, iOS will need this too I believe. Most of this is about the complexity inherent in the fact that a first sync needs to adopt account choices, and later it needs to be able to restore the per-account setting even if the local device now has different once (and I don't think this PR goes all the way for that one). It should work well with CWTS as it will be fine if the engine choices are known before that first sync. |
Okay, just checking. I was just wondering while Fenix was called out but the above explanation make sense. |
…ager
SyncResult.account_engine_choices reports meta/global's engines and declined, including a meta/global written by this sync, so apps using per-device engine choices can adopt them.
SyncParams.enabled_engines declares all the engines a device has chosen to sync, replacing DeviceSettings.enabled_engines. It doesn't decide what's synced, except that SyncEngineSelection::All means those engines.
sync-test checks the reported choices with either model and after a fresh start, and that enabled_engines is what SyncEngineSelection::All syncs.
This should get us very close to having Fenix be capable of using this model.
Pull Request checklist
[ci full]to the PR title.