Repository navigation
AC-240 Restructures RequestQueue to be a trait, adds a non-batching variant - #7802
Open
thesuzerain wants to merge 8 commits into
Open
thesuzerain wants to merge 8 commits into
thesuzerain wants to merge 8 commits into
Conversation
thesuzerain
commented
Nov 20, 2026
|
|
||
| // Thread sleep delay to wait for new requests to queue before resolving them. | ||
| // This must be a very short amount of time to ensure ads are requested near-immediately on startup. | ||
| pub const BATCH_GATHER_DURATION_DEFAULT: Duration = Duration::from_millis(100); |
Collaborator
Author
There was a problem hiding this comment.
Except for this now defaulting and being settable in new(), the rename, and some tests remaining in request.rs, this file is the same as request.rs used to be.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: Based on this comment, we will start without request batching and have a simple queue to start. Currently though, RequestQueue is designed around batching. So we want to have an alternate version that does not that we can switch between when we are ready/running a test.
This turns RequestQueue into a trait, the batching version into an implementation of said trait, and adds a simple queue version as well (basic FIFO, no batching).
There are fewer LoC here then it seems- a lot of it is because code is moved around.
No breaking changes here.
BackgroundWorkerdoes not exist yet.Pull Request checklist
[ci full]to the PR title.