fix: skip 'Game starting' message when resuming a saved game#185
Merged
fix: skip 'Game starting' message when resuming a saved game#185
Conversation
When resuming, the game log already contains the full event history from the save file. The unconditional "Game starting..." message was confusing because it appeared on top of that restored history. Now we detect resume by checking whether the phase is past Setup and send an empty initial state update instead (the TUI still gets the board state to render). Closes #178 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Investigation notes
Audited the full save/resume round-trip. All gameplay state (board, buildings, roads, resources, dev card deck order, robber position, longest road/army, friendly_robber, ports, phase, turn tracking) survives serialization correctly. The current player is always preserved accurately at turn boundaries.
Closes #178
Test plan
cargo test-- 436 tests pass (434 existing + 2 new)cargo fmtandcargo clippyclean🤖 Generated with Claude Code