fix: color trade offer resources by type instead of blanket green/red#183
Merged
fix: color trade offer resources by type instead of blanket green/red#183
Conversation
The trade response context bar colored all offered resources green and all wanted resources red, which conflicted with the per-resource color system used everywhere else. Now each resource in the trade offer is colored by its type (Wood=Green, Brick=Red, Sheep=LightGreen, Wheat=Yellow, Ore=Gray), matching the player panel and DESIGN.md spec. Fixes #180 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The trade response context bar colored all offered resources green and all wanted resources red. This conflicted with the per-resource color system used in the player panel and defined in DESIGN.md. Now each resource in the trade offer is colored by its type (Wood=Green, Brick=Red, Sheep=LightGreen, Wheat=Yellow, Ore=Gray), consistent with the rest of the UI.
Fixes #180
PR Type
Checklist
AI Usage
AI Model/Tool used: Claude Code (Claude Opus 4.6)
Any Additional AI Details you'd like to share: Fix implemented and reviewed by Claude Code.
NOTE:
When responding to reviewer questions, please respond yourself rather than copy/pasting reviewer comments into an AI and pasting back its answer. We want to discuss with you, not your AI :)