fix: return RuleViolation for invalid trades to prevent AI turn stalls#182
Merged
fix: return RuleViolation for invalid trades to prevent AI turn stalls#182
Conversation
After Monopoly depletes resources, the AI would propose trades offering resources it doesn't have. These invalid trades silently returned Ok(()), consuming action/trade slots and causing ~2-minute AI turns while the game appeared frozen. Now returns RuleViolation so invalid trades don't count, the AI moves on faster, and narration explains the failure. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ok(()), consuming action/trade slots and causing the AI turn to last ~2 minutes while the game appeared frozen.handle_tradeto returnErr(RuleViolation)whenvalidate_tradefails, so invalid trades don't count toward limits. Added narration message explaining the failure.Test plan
cargo clippycleancargo fmtclean🤖 Generated with Claude Code