Repository navigation
Fixes mosip/esignet#2667 Refactor mapper creation logic - #216
Merged
Merged
Conversation
Refactor mapper creation to use mapper_payload function for better maintainability and clarity. Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Ivanmeneges
changed the title
Ivanmeneges
changed the title
Updated README.md to reflect changes in audience mappers and client roles assignment. Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Expanded the README to include prerequisites, script usage, Docker instructions, theme application, and role assignment methods for Keycloak. Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Added details about Keycloak init script and audience mappers. Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Added comments for audience mapper configuration in clients section. Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Removed section on Keycloak init audience mappers and related YAML example from the README. Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Updated guidance on Keycloak init mappers, including details on protocol mappers and audience entries. Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
…oak`. ## Keycloak init mappers `keycloak-init/keycloak_init.py` already creates protocol mappers. Each client `mappers` entry is passed to `create_mapper`, which calls `mapper_payload`. - Leave `protocol_mapper` unset to keep `oidc-usermodel-attribute-mapper`. Those entries use `mapper_name`, `mapper_user_attribute`, and `token_claim_name`. - Set `protocol_mapper: oidc-audience-mapper` and `included_client_audience` or `included_custom_audience` to add that value to the access token `aud`. The script sets `access.token.claim` to `true`. - Pass the new entry through the existing `mappers` list. Do not add another mapper implementation. - A re-run skips a mapper name that already exists. The stored mapper is left as it is. - The old script rejects an audience entry because it still requires `mapper_user_attribute`. - Chart mapper lists live in `helm/keycloak-init directory Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Document guidance for coding agents in mosip/keycloak, including details on Keycloak init mappers and their configuration. Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Clarified behavior of mappers and role assignment in Keycloak. Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Clarified protocol mapper descriptions and added checks for audience mappers. Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Refactor mapper_payload function to improve audience validation and configuration handling. Add validate_configured_mappers function to check mapper entries before realm or client creation. Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Clarify protocol mapper requirements in README. Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Updated comments for clarity regarding audience configuration and ensured proper formatting in keycloakExternalHost. Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Expanded guidance for coding agents in the `mosip/esignet` repository, detailing subproject layout, working across subprojects, and conventions. Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
ckm007
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor mapper creation to use mapper_payload function for better maintainability and clarity.