perf(bigint): cache decimal division reciprocal - #4188
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Coverage Report for CI Build 6498Coverage remained the same at 90.976%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
c4ca463 to
a6bc339
Compare
|
Perf sign-off ✅ Reviewed the change and verified it on this machine (absolute numbers differ from the PR's box, but the trend is what matters). Correctness
Perf —
The native win is exactly what the change predicts — one software LGTM, thanks for the clean hoist 👍 |
Summary
10^19divisor with shift zero in every decimal conversionPerformance
Native release benchmark (
moon bench bigint/to_string_bench_test.mbt --target native --release):Validation
moon check --deny-warn --target allmoon info --target wasm,wasm-gc,js,native(no.mbtichanges)moon fmtmoon test --target allmoon test --release --target allmoon bundle --all