Skip to content

v0.9.29 Dependency Update#1825

Merged
notlesh merged 71 commits into
masterfrom
moonbeam-polkadot-v0.9.29
Oct 6, 2022
Merged

v0.9.29 Dependency Update#1825
notlesh merged 71 commits into
masterfrom
moonbeam-polkadot-v0.9.29

Conversation

@notlesh

@notlesh notlesh commented Sep 21, 2022

Copy link
Copy Markdown
Contributor

What does it do?

Updates Moonbeam and friends to the Polkadot v0.9.29 release. "Fixes" #1814

⚠️ Breaking Changes ⚠️

⚠️ CLI parameters --keep-blocks and --pruning changed paritytech/substrate#11934
⚠️ Weights are now a struct instead of a u64
⚠️ 🐛 pays_fee is now properly recorded and reflected in APIs. This means that some extrinsics (including Ethereum txns) and inherents will now correctly report pays_fee: No or paysFee: false whereas they incorrectly reported Yes previously. paritytech/substrate#11849
🎉 try-runtime::follow-chain gets a --keep-connection flag: paritytech/substrate#12167
🎉 Caching should be usable: paritytech/substrate#11407

TODO

Comment thread Cargo.toml
Comment thread node/Cargo.toml
Comment thread rust-toolchain
Comment thread pallets/parachain-staking/src/weights.rs Outdated
Comment thread pallets/randomness/Cargo.toml Outdated
@notlesh notlesh added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. dependencies Pull requests that update a dependency file labels Sep 22, 2022
Comment thread tests/tests/test-eth-fee/test-eth-paysFee.ts Outdated
Comment thread tests/util/block.ts
Comment thread tests/util/block.ts Outdated
Comment thread Cargo.toml Outdated
@notlesh notlesh added the A0-pleasereview Pull request needs code review. label Oct 5, 2022

@girazoki girazoki left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see anything fundamentally wrong. I will keep reviewing the PRs you noted above though

@crystalin

Copy link
Copy Markdown
Collaborator

@notlesh I don't see the payFees::no change of Frontier in the breaking changes of this PR

@tgmichel

tgmichel commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

@notlesh with the inclusion of moonbeam-foundation/frontier@fe12fdd we need to bump web3 js version to ^1.8.0 that supports the new safe and finalized block tags. Rel #1831

@notlesh notlesh merged commit 93698c5 into master Oct 6, 2022
@notlesh notlesh deleted the moonbeam-polkadot-v0.9.29 branch October 6, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A0-pleasereview Pull request needs code review. B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants