🔥 DOP-4290 removes Manifest.py and Document.py as part of the deprecating of the legacy tooling support

[caesarbell]

No description provided.

[anabellabuckvar]

Thanks for this! README looks great. Two notes

1. I think there are a few dependencies that were only used in Document.py and/or Manifest.py, such as html5_parser and lxml(but possibly more). What do you think about checking and removing such dependencies from setup.py and pyroject.toml?
2. I could be wrong, but it seems like there is still some code for legacy tooling that uses giza/sphinx and deals with building manifests from an html document. I noticed this in convert_redirects, for example, but please ignore if you already saw that code and decided to leave it in!

[caesarbell]

Thanks for this! README looks great. Two notes

1. I think there are a few dependencies that were only used in Document.py and/or Manifest.py, such as html5_parser and lxml(but possibly more). What do you think about checking and removing such dependencies from setup.py and pyroject.toml?
2. I could be wrong, but it seems like there is still some code for legacy tooling that uses giza/sphinx and deals with building manifests from an html document. I noticed this in convert_redirects, for example, but please ignore if you already saw that code and decided to leave it in!

@anabellabuckvar good catch, I also removed it from those dependencies from requirement.txt as well. As for the convert_redirects.py, how can I confirm that this was used for legacy tooling?

[anabellabuckvar]

Thanks for this! README looks great. Two notes

1. I think there are a few dependencies that were only used in Document.py and/or Manifest.py, such as html5_parser and lxml(but possibly more). What do you think about checking and removing such dependencies from setup.py and pyroject.toml?
2. I could be wrong, but it seems like there is still some code for legacy tooling that uses giza/sphinx and deals with building manifests from an html document. I noticed this in convert_redirects, for example, but please ignore if you already saw that code and decided to leave it in!

@anabellabuckvar good catch, I also removed it from those dependencies from requirement.txt as well. As for the convert_redirects.py, how can I confirm that this was used for legacy tooling?

I'm not sure, it mentions giza-style redirects and versions, but this will likely need further investigation or others on the team might have insight as to whether those code components are still necessary

[caesarbell]

Thanks for this! README looks great. Two notes

1. I think there are a few dependencies that were only used in Document.py and/or Manifest.py, such as html5_parser and lxml(but possibly more). What do you think about checking and removing such dependencies from setup.py and pyroject.toml?
2. I could be wrong, but it seems like there is still some code for legacy tooling that uses giza/sphinx and deals with building manifests from an html document. I noticed this in convert_redirects, for example, but please ignore if you already saw that code and decided to leave it in!

@anabellabuckvar good catch, I also removed it from those dependencies from requirement.txt as well. As for the convert_redirects.py, how can I confirm that this was used for legacy tooling?

I'm not sure, it mentions giza-style redirects and versions, but this will likely need further investigation or others on the team might have insight as to whether those code components are still necessary

@anabellabuckvar, fair, so for learning purposes, giza/sphinx technology was only used for legacy tooling? I will raise with the team our question about convert_redirects being solely used for legacy tooling.

[anabellabuckvar]

Looks good! Last thing is make sure to remove the convert-redirects script and any references to it

[anabellabuckvar]

Thanks for this! README looks great. Two notes

1. I think there are a few dependencies that were only used in Document.py and/or Manifest.py, such as html5_parser and lxml(but possibly more). What do you think about checking and removing such dependencies from setup.py and pyroject.toml?
2. I could be wrong, but it seems like there is still some code for legacy tooling that uses giza/sphinx and deals with building manifests from an html document. I noticed this in convert_redirects, for example, but please ignore if you already saw that code and decided to leave it in!

@anabellabuckvar good catch, I also removed it from those dependencies from requirement.txt as well. As for the convert_redirects.py, how can I confirm that this was used for legacy tooling?

I'm not sure, it mentions giza-style redirects and versions, but this will likely need further investigation or others on the team might have insight as to whether those code components are still necessary

@anabellabuckvar, fair, so for learning purposes, giza/sphinx technology was only used for legacy tooling? I will raise with the team our question about convert_redirects being solely used for legacy tooling.

AFAIK, yes, those are legacy and we will no longer be supporting that tooling

[anabellabuckvar]

LGTM :)