Update README.md#69
Merged
Merged
Conversation
Add note about changing permissions to install poetry
mmeigs
reviewed
Nov 6, 2023
| 2. Build a wheel using `poetry build`. | ||
|
|
||
| > [!NOTE] | ||
| > You may need to add read privaleges to your *Users/\<your-username>/.pyenv/* folder. |
Collaborator
There was a problem hiding this comment.
Looks good! Total nitpick, but can we spell it "privileges" just so no one gets confused about if we're referencing a python library or anything else. Also, is there a reason there's a backslash (\) before <your-username>?
Contributor
Author
There was a problem hiding this comment.
If you take a look at the README on the branch you can see that the backslash doesn't show up - it's just a necessary escape character within the brackets.
mmeigs
approved these changes
Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add note about changing permissions to install poetry - I'm sure how much detail I should add.
e.g. In order to view the folder in Finder, I had to use the Reveal in Finder option from VS code.