Skip to content

fix(openrouter): close final config and doctor gaps - #609

Merged
aviggiano merged 5 commits into
mainfrom
fix/586-final-gates
Aug 15, 2026
Merged

aviggiano merged 5 commits into
mainfrom
fix/586-final-gates

Conversation

@aviggiano

@aviggiano aviggiano commented Aug 15, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • keep OpenRouter explicitly opt-in so legacy agent registries remain valid
  • propagate doctor --topology-path through CLI and runtime validation/credential discovery
  • align canonical config/schema fixtures, tests, and both configuration guides

Context

PR #586 merged before its final review and smoke gates completed. This focused follow-up closes the two remaining compatibility and Doctor topology-override gaps without expanding provider scope.

Validation

  • exact-SHA Smithers review: 13 files, six gpt-5.6-sol xhigh file passes, 0 findings
  • config, runtime, CLI focused tests/typechecks and docs checks passed before the final rebase
  • final-SHA local gates, CI, and the three-target OpenRouter smoke are required before merge

No release, tag, or publication is part of this PR.

Greptile Summary

The PR makes OpenRouter model profiles explicitly opt-in and consistently applies Doctor topology overrides during validation and credential discovery.

  • Removes the OpenRouter profile from canonical defaults and aligns fixtures and documentation.
  • Revalidates effective model profiles after runtime agent/model overrides.
  • Adds doctor --topology-path and propagates it through topology validation and OpenRouter credential checks.
  • Adds focused CLI, runtime, and schema coverage for the revised behavior.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
packages/cli/src/commands/doctor.ts Adds the topology override flag and passes it directly to the runtime Doctor API.
packages/runtime/src/doctor.ts Applies the selected topology consistently to project validation, active-agent discovery, credential checks, and required-command posture.
packages/runtime/src/validate.ts Preserves pre-override registry requirements and validates the effective model profile after runtime overrides.
packages/runtime/src/types.ts Extends DoctorInput with the optional topology override used by CLI and runtime callers.
ultrafuzz.toml Removes the canonical OpenRouter model profile so projects must opt in explicitly.
packages/runtime/test/model-override-validation.test.ts Covers invalid and valid effective OpenRouter overrides and preservation of configured-agent registry checks.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  CLI["doctor --topology-path"] --> Runtime["diagnoseProject"]
  Runtime --> Validate["validateProject(topologyPath)"]
  Runtime --> Refs["activeTopologyAgentRefs(topologyPath)"]
  Validate --> Posture["Topology policy posture"]
  Refs --> Credentials["OpenRouter credential check"]
Loading

Reviews (4): Last reviewed commit: "fix(runtime): validate effective OpenRou..." | Re-trigger Greptile

Context used (3)

@aviggiano

Copy link
Copy Markdown
Collaborator Author

Rollout gate clarification: no live paid OpenRouter or audit smoke will be launched for this follow-up. The stale session requirement in the PR body is superseded by the maintainer constraint for this pass. This config/Doctor-only bugfix remains gated by exact-head deterministic CI, post-ready Greptile, independent code review, and exact-merge-commit main CI.

@aviggiano
aviggiano merged commit 45d92f0 into main Aug 15, 2026
13 of 16 checks passed
@aviggiano
aviggiano deleted the fix/586-final-gates branch August 15, 2026 13:50
@aviggiano

Copy link
Copy Markdown
Collaborator Author

Cross-task coordination acknowledgment (2026-08-15 14:45 UTC): the explicitly authorized exact-f1832ae6 manual smoke has a safe enable → dispatch → immediate-disable window now. This task will not push or merge main and will not cancel that next manual run. Existing #608 main CI and #603 PR CI are read-only with respect to main. Please keep workflow 316356297 enabled only for dispatch, disable immediately afterward, and report the run ID plus disabled_manually confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant