Repository navigation
Conversation
aviggiano
marked this pull request as ready for review
August 12, 2026 18:33
Comment on lines
+428
to
+429
| positive_test_paths: nonEmptyStringArray, | ||
| negative_test_paths: nonEmptyStringArray, |
There was a problem hiding this comment.
Evidence paths remain unauthenticated
When an implementation record names nonexistent or unrelated positive, negative, or reachability evidence paths, the @3 validator checks only that those strings are nonempty, and campaign admission still credits the property as implemented, allowing a campaign with no executable regression or reachability proof to be reported as complete.
Knowledge Base Used:
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/artifacts/src/property-provenance.ts
Line: 428-429
Comment:
**Evidence paths remain unauthenticated**
When an implementation record names nonexistent or unrelated positive, negative, or reachability evidence paths, the `@3` validator checks only that those strings are nonempty, and campaign admission still credits the property as implemented, allowing a campaign with no executable regression or reachability proof to be reported as complete.
**Knowledge Base Used:**
- [Artifacts](https://app.greptile.com/monad-foudnation/-/custom-context/knowledge-base/monad-developers/ultrafuzz/-/docs/artifacts.md)
- [Runtime: Run Orchestration Lifecycle](https://app.greptile.com/monad-foudnation/-/custom-context/knowledge-base/monad-developers/ultrafuzz/-/docs/runtime.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Collaborator
Author
|
Closing without merge per updated scope: issues labeled |
This was referenced Aug 14, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@3evidenceFixes #519
Fixes #524
Greptile Summary
The PR replaces legacy implemented-property contracts with an
@3evidence contract and adds campaign admission checks intended to prevent false invariant-coverage claims.@1and@2implemented-property contract handling.Confidence Score: 4/5
The PR should not merge until the new evidence paths are tied to real declared artifacts, because unsupported property implementations can currently receive complete campaign credit.
The new strict contract requires evidence fields but validates only their textual presence, while campaign admission trusts the resulting implemented record without checking that the referenced regressions or reachability proof exist.
Files Needing Attention: packages/artifacts/src/property-provenance.ts, packages/runtime/src/artifact-gates.ts
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR P[Implementation agent] --> I[implemented-properties @3] I --> V[Artifact schema validation] V --> C[Invariant campaign] C --> A[Admission checks] A --> R[Final report] T[Regression and reachability paths] -. currently checked only for nonempty strings .-> VPrompt To Fix All With AI
Reviews (1): Last reviewed commit: "test(invariants): enforce current oracle..." | Re-trigger Greptile
Context used (4)