Repository navigation
fix(runtime): join report backends through finding aliases - #437
Merged
Merged
Conversation
aviggiano
force-pushed
the
fix/404-report-source-finding-backend
branch
from
August 9, 2026 02:47
916ee2b to
4352d2e
Compare
Comment on lines
+3191
to
+3204
| const lifecycleFindingIds = new Set( | ||
| outcome.lifecycle.source_artifacts.flatMap((source) => | ||
| isRecord(source) && | ||
| campaignLogicalNodeIds.some((nodeId) => nodeId === source.node_id) && | ||
| source.relationship === "primary" && | ||
| typeof source.finding_id === "string" | ||
| ? [source.finding_id] | ||
| : [] | ||
| ) | ||
| ); | ||
| for (const alias of stringArray([outcome.finding_id, outcome.upstream_id, outcome.source_finding_id])) { | ||
| if (lifecycleFindingIds.has(alias)) { | ||
| verifiedAliases.add(alias); | ||
| } |
There was a problem hiding this comment.
Report assertions verify their own aliases
When a property-provenance entry claims an existing campaign finding as an alias and its matching report outcome supplies a fabricated primary lifecycle source for that finding, verifiedReportFindingAliases treats the report-authored lifecycle assertion as verification and imports the real campaign backend. The unrelated finding then avoids PROPERTY_REPORT_FUZZER_BACKEND_MISMATCH despite having no genuine campaign provenance.
Knowledge Base Used: Runtime: Run Orchestration Lifecycle
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/runtime/src/artifact-gates.ts
Line: 3191-3204
Comment:
**Report assertions verify their own aliases**
When a property-provenance entry claims an existing campaign finding as an alias and its matching report outcome supplies a fabricated primary lifecycle source for that finding, `verifiedReportFindingAliases` treats the report-authored lifecycle assertion as verification and imports the real campaign backend. The unrelated finding then avoids `PROPERTY_REPORT_FUZZER_BACKEND_MISMATCH` despite having no genuine campaign provenance.
**Knowledge Base Used:** [Runtime: Run Orchestration Lifecycle](https://app.greptile.com/monad-foudnation/-/custom-context/knowledge-base/monad-developers/ultrafuzz/-/docs/runtime.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finding_id,upstream_id, andsource_finding_idLive evidence
Aave v4 invariant-only R59 reached 31/32 successful nodes.
final-reportemitted presentation IDNP-01, retained campaign IDfailure-1assource_finding_id, and correctly recorded backendrecon. The artifact gate looked up onlyNP-01, inferred no campaign backend, and rejected it withPROPERTY_REPORT_FUZZER_BACKEND_MISMATCH/Report fuzzer backends do not match the campaign records.This PR fixes that newly exposed final-node blocker. A fresh externally owned live run is still required before #404 can close; this host does not have the uncommitted
.ultrafuzz/modal/benchmark.jsonlaunch configuration.Refs #404
Validation
git diff --checkpassedGreptile Summary
The PR extends final-report backend joins across presentation and source finding IDs while attempting to constrain aliases through lifecycle provenance.
Confidence Score: 4/5
The PR is not safe to merge until report aliases are verified against independent campaign provenance rather than lifecycle claims from the report itself.
The previously reported backend-borrowing path remains reachable despite the reply claiming it was fixed: a report can coordinate its alias with a fabricated primary lifecycle source, causing the new helper to admit an unrelated real campaign finding and use its backend.
Files Needing Attention: packages/runtime/src/artifact-gates.ts, packages/runtime/test/artifact-gates.test.ts
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR P[Property provenance alias] --> O[Matching report outcome] O --> L[Report-authored primary lifecycle source] L --> A[Alias admitted] A --> C[Campaign backend map lookup] C --> G[Backend provenance gate]Prompt To Fix All With AI
Reviews (3): Last reviewed commit: "fix(runtime): bind report aliases to lif..." | Re-trigger Greptile
Context used: