Repository navigation
fix(runtime): support Modal descriptor device splits - #431
Merged
Merged
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
st_devvalues for a stable parent directory and its child filesLive reproduction
The exact
origin/mainrunner image used by public benchmark run31285069172reports device19for the opened target directory and device17for a child created through/proc/self/fd/<dirfd>; the lexical child has the same device/inode as the opened child. Before this change, freshultrafuzz init --force --jsonexits 1 withINIT_PATH_UNSAFEafter writing onlyultrafuzz.toml.Injecting the compiled fix into that same image makes all of these succeed:
Validation
@ultrafuzz/runtimefull suite: 183 passed, 16 expected skips, 0 failedUnblocks the public benchmark acceptance required by #427. This PR does not close #427; complete 3/3 benchmark, cost/wall-clock, and supersession evidence still need to land.
Greptile Summary
The PR adjusts init-time filesystem identity validation for environments where directory descriptors and their child files report different devices, while retaining opened-versus-lexical file checks.
Confidence Score: 5/5
The PR appears safe to merge because the relaxed parent-device checks retain direct opened-versus-lexical identity validation and atomic sidecars remain bound to the target file’s device.
The changed checks align device validation with the identities used by file writes, hard links, and renames, and the added regression test exercises both valid split-device behavior and deliberate identity mismatch rejection.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD D[Open and authenticate parent directory] --> C[Open or create child through directory descriptor] C --> I{Existing target?} I -->|Yes| E[Match opened child to expected target dev and inode] I -->|No| L[Match opened child to lexical child dev and inode] E --> L L --> W[Write and fsync child] W --> V[Revalidate opened child, lexical child, and parent directory] V --> A{Atomic adapter migration?} A -->|Yes| S[Create sidecars sharing original target device] S --> P[Rename, hard-link, verify, and clean up] A -->|No| F[Finish initialization]Reviews (1): Last reviewed commit: "fix(runtime): support Modal descriptor d..." | Re-trigger Greptile
Context used: