Repository navigation
Anchor Smithers executable identity at command boundaries - #421
Merged
Merged
Conversation
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second of the three ordered priority-8 replacements for the obsolete #165 branch.
This slice adds a non-forgeable Smithers executable capability and binds it at each buffered and streaming command boundary. The runtime verifies the exact local runner, its shebang interpreter, and the held descriptor or lexical identity before and after execution, so PATH substitution or pathname replacement cannot silently run different bytes.
This intentionally excludes control-file sealing, execution snapshots, lifecycle rewrites, Modal, evals, and CI. The third replacement slice will add the dependent control seal and its verification call sites.
Verification:
Part of #413 and the second replacement slice for #165.
Greptile Summary
The PR adds a non-forgeable capability for the pinned local Smithers executable and verifies the runner and its shebang interpreter at buffered and streaming command boundaries.
Confidence Score: 5/5
The PR appears safe to merge, with no concrete correctness, security, or lifecycle failure identified in the changed paths.
The command paths retain runner and interpreter anchors through child termination, verify their identities before and after execution, and close acquired descriptors across success and failure paths.
Important Files Changed
Sequence Diagram
Reviews (1): Last reviewed commit: "fix(runtime): anchor Smithers executable..." | Re-trigger Greptile
Context used: