Repository navigation
fix(runtime): name the group pin a node timeout pin falls back to (#675) - #1273
Merged
Merged
Conversation
Follow-up to #1256. - A node pin inside a group that also pins falls back to the group pin when removed, not to the profile or run default. The warning now says so and names the group pin, instead of "remove the pin to use the longer default". - validate, doctor and run report the warning; there is no plan command. Fix the docs and CHANGELOG. - The 7200 s pins did not cause the goal node timeouts in #675 (the oversized goal statement did, #680/#690). Keep only the resolution order claim in the CHANGELOG and the doc comment. - Test that a pin equal to the default stays silent, and that a node fanned out to several profiles is reported against the longest one. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
aviggiano
added a commit
that referenced
this pull request
Oct 6, 2026
- Predict `OpenRouterAgent`'s home (`<root>/openrouter`), which its adapter requires to be 0700 like DeepSeek's; the Bun parity test covers it.
- Report a relative `CODEX_HOME`, `CLAUDE_CONFIG_DIR`, `KIMI_CODE_HOME` or `KIMI_SHARE_DIR` as `PROVIDER_HOME_UNSAFE` ("set it to an absolute path"), as the adapters refuse it, instead of resolving it against the cwd.
- Without `HOME` in the launch environment, fall back to `os.homedir()` as the adapters do, instead of skipping the check.
- Quote the path in the printed `chmod 700` / `chmod go-w` command when it needs quoting, and report an unsearchable directory with `chmod u+x <parent>`, naming the directory that blocks the search.
- Drop the `index.ts` re-export; only `validate.ts` uses the module.
- Give a private `HOME` to the tests that validate a project with no environment, with `env: {}`, or with an environment that has neither `HOME` nor `ULTRAFUZZ_PROVIDER_HOME_ROOT`. This covers the dashboard prompt-save test, which otherwise falls back to `process.env`, and the two #1273 timeout-pin tests.
- Fold the follow-up into the existing #1265 CHANGELOG entry instead of adding a second one.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1256 (issue #675).
Problem
timeout_secondsinside a group that also pins, theTOPOLOGY_TIMEOUT_SHADOWS_DEFAULTwarning says "Raise or remove the pin to use the longer default." Removing the node pin falls back to the group pin, not to the profile or run default. Example: group pin 7200, node pin 3000, run default 3600. The warning compares the node pin against 3600, but removing the node pin gives 7200.validate,planandrunreport the warning. There is no user-facingplancommand.doctordoes show it, because it reports the validation diagnostics.<=boundary). No test covered a node fanned out to several model profiles with different timeouts.Change
timeout-shadowing.ts: for a node pin whose group also pins, the message now ends with "Raise the pin, or remove it to fall back togroups.<g>.defaults.timeout_seconds=." Other pins keep the old text. The comparison and the set of reported pins do not change.timeout-shadowing.tsand the CHANGELOG now keep only the resolution-order claim.docs/reference/configuration.mdand the CHANGELOG now sayvalidate,doctorandrun.Tests
claude(5400),deepseek(10800) anddefault(run default 3600) with a 1800 pin is reported once, against model profiledeepseek(10800).<=to<fails the boundary test.timeout|doctorand^validate|^plan, eslint and prettier on changed files,pnpm --filter @ultrafuzz/runtime typecheck,ESLINT_PLUGIN_DIFF_COMMIT=origin/unstable pnpm -w lint:strict:ci,pnpm -w docs:check.🤖 Generated with Claude Code
The PR appears safe to merge; no actionable issue was found in its changeset.
Summary
This PR clarifies timeout-shadowing diagnostics for node pins inside pinned groups, corrects the documented commands that report the warning, and adds boundary and model-fan-out coverage.
Reviews (2) · Last reviewed commit: "Merge branch 'unstable' into fix/675-tim..."