Repository navigation
Remove Braintrust reporting and implicit judge gateway - #1134
Merged
Merged
Conversation
| [--project <path>] \ | ||
| [--suite <suite-yaml-path>] \ | ||
| [--provider braintrust|none] \ | ||
| [--provider none] \ |
There was a problem hiding this comment.
Provider documentation is stale
Only none is now supported, but this reference still says provider bindings and credential names configure a reporter and that eval run streams telemetry to that provider. This describes a configuration path that no longer exists and can mislead users. Update the prose and command summary to describe local telemetry only; docs/cli.md:36 contains the same stale wording.
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/reference/cli.md
Line: 637
Comment:
**Provider documentation is stale**
Only `none` is now supported, but this reference still says provider bindings and credential names configure a reporter and that `eval run` streams telemetry to that provider. This describes a configuration path that no longer exists and can mislead users. Update the prose and command summary to describe local telemetry only; `docs/cli.md:36` contains the same stale wording.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
aviggiano
force-pushed
the
codex/1133-remove-braintrust
branch
from
September 22, 2026 21:54
a055e35 to
fba4872
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1133
The codebase still contained a Braintrust HTTP reporter, credential forwarding, remote telemetry publication, and an implicit Braintrust gateway for optional LLM judging after the paid-CI cleanup. This removes those integrations and the
eval publishCLI/library API. Local eval history, durable artifacts, reports, deterministic scoring, comparison, bundles, and generic telemetry observers remain available.Reporting accepts only
none; unsupported providers fail before credential access, network activity, or run-state creation. Historical provider metadata can still decode but cannot activate a reporter, and an explicit--provider nonecan override legacy settings. Optional LLM judging now requires bothULTRAFUZZ_EVAL_JUDGE_URLand its dedicated judge key, preserving HTTPS validation, redirect rejection, bounded responses, and private-data consent. There is no implicit replacement service.Migration: Modal benchmark configuration is now
ultrafuzz.modal.benchmark.v3, with a vendor-neutraljudgeobject and no reporting credentials or provider switch. Regenerate configurations for new runs using the documented migration. Existing v2 configurations are rejected rather than rewritten; existing sandboxes can still be terminated using their launch state alone. Updated manual benchmark generators, collection tooling, schemas, fixtures, defaults, and documentation follow this contract.Validation passed without paid inference or cloud workloads:
The repository's
BRAINTRUST_API_KEYActions secret was already removed; provider-side key revocation remains an account-owner operation.The PR appears safe to merge, with no outstanding previous finding or newly identified actionable defect.
Fix with agent prompt
Summary
Removes Braintrust reporting, credential forwarding, remote telemetry publication, and the
eval publishsurface while preserving local evaluation artifacts and generic telemetry observers.noneprovider and keeps historical provider metadata inert.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR A[Eval plan] --> B[Eval run] B --> C[Local journals and artifacts] C --> D[Deterministic scoring] C --> E[Local reports and comparisons] C --> F[Generic telemetry observers] D -->|Optional LLM judge| G{Explicit judge URL and key configured?} G -->|Yes| H[HTTPS judge endpoint] G -->|No| I[Fail closed] C -. no built-in reporter .-> J[No remote Braintrust publication]Reviews (4) · Last reviewed commit: "Remove obsolete eval publishing guidance"