Skip to content

Improve Simplified Chinese localization across cleanup and maintenance tools - #180

Merged
momenbasel merged 1 commit into
momenbasel:mainfrom
0x00kh:feat/improve-chinese-localization
Oct 8, 2026
Merged

momenbasel merged 1 commit into
momenbasel:mainfrom
0x00kh:feat/improve-chinese-localization

Conversation

@0x00kh

@0x00kh 0x00kh commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

PureMac still shows English text in several cleanup and maintenance workflows when Simplified Chinese is selected. This PR completes the Simplified Chinese string catalog and routes dynamic UI text through localization so progress, status messages, dialogs, and errors use the selected language.

  • Translate the current dashboard, cleanup review, app uninstaller, Duplicate Finder, Similar Photos, Space Explorer, App Updates, Performance, Protection, and Time Machine snapshot workflows.
  • Localize runtime strings in services and view models, folder picker text, status chips, and reusable message titles.
  • Add Simplified Chinese macOS permission prompts and the Finder Services menu entry, and register both resources in the Xcode project.
  • Add 405 localization keys, with English fallback values in the other supported locales to preserve key parity.
  • Extend localization tests to check bundled Simplified Chinese resources, reject untranslated English placeholders except approved product names, and validate additional numeric format specifiers.

Type of change

  • Bug fix
  • New feature
  • Performance improvement
  • UI/UX enhancement
  • Documentation
  • Other: Localization

Testing

  • git diff --check passed for the localization commit.
  • plutil -lint passed for all 21 localization resource files.
  • A source-level validation script confirmed that all 11 locales contain the same 802 keys, have no duplicate keys, and preserve English format specifiers.
  • The same script confirmed that Simplified Chinese has no unchanged English values except the four approved names (PureMac, PureMac.app, CPU, and XProtect).
  • Xcode build and XCTest suite: not run because this environment has Command Line Tools but no full Xcode installation. The source-level checks above do not validate the built app bundle or runtime UI.
  • Tested on macOS Ventura (13.x)
  • Tested on macOS Sonoma (14.x)
  • Tested on macOS Sequoia (15.x)

Screenshots

Not captured; interactive UI verification remains pending.

…cross cleanup and maintenance tools

Localize dynamic statuses, progress, dialogs, errors, permissions, and Time Machine snapshot workflows. Add locale fallbacks and validate format placeholders to prevent malformed translations.
@momenbasel

Copy link
Copy Markdown
Owner

Merged into #184 as the zh-Hans base (merge 2040b9e): the only candidate that kept key parity and passed the suite, with every one of its 405 keys reachable because of its Swift changes. Follow-ups on top (5c8a38b): the English plural regressions ("1 files", "3 file(s)") are back to singular and plural forms through "1 file", "1 folder" and the "%lld files" keys; nine legacy zh-Hans values take full-width punctuation and the "Older than 30 days" wording from #181; "Purgeable" uses Apple's term; and testSimplifiedChineseHasNoEnglishPlaceholderValues is removed, since the repo convention is English fallbacks for new keys. Ships in 3.1.0; thanks.

@momenbasel momenbasel mentioned this pull request Oct 8, 2026
1 of 9 tasks
0x00kh pushed a commit to 0x00kh/PureMac that referenced this pull request Oct 8, 2026
0x00kh pushed a commit to 0x00kh/PureMac that referenced this pull request Oct 8, 2026
…nbasel#180 and momenbasel#167

German gets English fallbacks for the 406 keys the other locales received
in momenbasel#180, so the catalogs stay in parity, and its "Clear" now matches the
clear-selection button that key is used for. The "1 files" and "3 file(s)"
strings momenbasel#180 introduced go back to proper singular and plural forms through
"1 file", "1 folder", "%lld files" and "%lld folders" keys in every locale.
zh-Hans takes the full-width punctuation, the "Older than" wording and
Apple's term for purgeable space from momenbasel#181 by @BruceQin520.

The zh-Hans-only completeness test is removed: the repo convention is
English fallbacks for new keys, and that test would fail on every future key
until it is translated.
0x00kh pushed a commit to 0x00kh/PureMac that referenced this pull request Oct 8, 2026
Translation by @BinaryBearsLLC from momenbasel#174 (commit 8c20a93), re-cut on top of momenbasel#180, momenbasel#167 and the other momenbasel#174 commits.

it.lproj/Localizable.strings follows the current en key set and file order: 829 values come from the momenbasel#174 Italian catalog and 23 keys that did not exist there keep the English text as a fallback (the filter labels, memory and admin-removal messages added by momenbasel#180). "German" is rendered as "Tedesco" and "App Updates" as the noun phrase "Aggiornamenti app" because the key is used as a navigation title and sidebar label. InfoPlist.strings and ServicesMenu.strings are taken unchanged. The "Italian" language name is added to all 12 existing locales, .italian to AppLanguage, the it bundle to the localization tests, and the README Settings paragraph mentions Italian.

The second half of momenbasel#174, a refactor that routed service and view-model strings through String(localized:) and added 432 keys to every locale, was not taken: momenbasel#180 already landed the same change on this branch and the two rewrites of the same lines conflict.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants