Repository navigation
Improve Simplified Chinese localization across cleanup and maintenance tools - #180
Merged
momenbasel merged 1 commit intoOct 8, 2026
Merged
Conversation
…cross cleanup and maintenance tools Localize dynamic statuses, progress, dialogs, errors, permissions, and Time Machine snapshot workflows. Add locale fallbacks and validate format placeholders to prevent malformed translations.
This was referenced Oct 8, 2026
This was referenced Oct 8, 2026
Owner
|
Merged into #184 as the zh-Hans base (merge 2040b9e): the only candidate that kept key parity and passed the suite, with every one of its 405 keys reachable because of its Swift changes. Follow-ups on top (5c8a38b): the English plural regressions ("1 files", "3 file(s)") are back to singular and plural forms through "1 file", "1 folder" and the "%lld files" keys; nine legacy zh-Hans values take full-width punctuation and the "Older than 30 days" wording from #181; "Purgeable" uses Apple's term; and testSimplifiedChineseHasNoEnglishPlaceholderValues is removed, since the repo convention is English fallbacks for new keys. Ships in 3.1.0; thanks. |
1 of 9 tasks
0x00kh
pushed a commit
to 0x00kh/PureMac
that referenced
this pull request
Oct 8, 2026
0x00kh
pushed a commit
to 0x00kh/PureMac
that referenced
this pull request
Oct 8, 2026
…nbasel#180 and momenbasel#167 German gets English fallbacks for the 406 keys the other locales received in momenbasel#180, so the catalogs stay in parity, and its "Clear" now matches the clear-selection button that key is used for. The "1 files" and "3 file(s)" strings momenbasel#180 introduced go back to proper singular and plural forms through "1 file", "1 folder", "%lld files" and "%lld folders" keys in every locale. zh-Hans takes the full-width punctuation, the "Older than" wording and Apple's term for purgeable space from momenbasel#181 by @BruceQin520. The zh-Hans-only completeness test is removed: the repo convention is English fallbacks for new keys, and that test would fail on every future key until it is translated.
0x00kh
pushed a commit
to 0x00kh/PureMac
that referenced
this pull request
Oct 8, 2026
Translation by @BinaryBearsLLC from momenbasel#174 (commit 8c20a93), re-cut on top of momenbasel#180, momenbasel#167 and the other momenbasel#174 commits. it.lproj/Localizable.strings follows the current en key set and file order: 829 values come from the momenbasel#174 Italian catalog and 23 keys that did not exist there keep the English text as a fallback (the filter labels, memory and admin-removal messages added by momenbasel#180). "German" is rendered as "Tedesco" and "App Updates" as the noun phrase "Aggiornamenti app" because the key is used as a navigation title and sidebar label. InfoPlist.strings and ServicesMenu.strings are taken unchanged. The "Italian" language name is added to all 12 existing locales, .italian to AppLanguage, the it bundle to the localization tests, and the README Settings paragraph mentions Italian. The second half of momenbasel#174, a refactor that routed service and view-model strings through String(localized:) and added 432 keys to every locale, was not taken: momenbasel#180 already landed the same change on this branch and the two rewrites of the same lines conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PureMac still shows English text in several cleanup and maintenance workflows when Simplified Chinese is selected. This PR completes the Simplified Chinese string catalog and routes dynamic UI text through localization so progress, status messages, dialogs, and errors use the selected language.
Type of change
Testing
git diff --checkpassed for the localization commit.plutil -lintpassed for all 21 localization resource files.PureMac,PureMac.app,CPU, andXProtect).Screenshots
Not captured; interactive UI verification remains pending.