Skip to content

[1/6] Add a dedicated Settings page - #169

Closed
BinaryBearsLLC wants to merge 1 commit into
momenbasel:mainfrom
BinaryBearsLLC:Upgrade-01-settings
Closed

BinaryBearsLLC wants to merge 1 commit into
momenbasel:mainfrom
BinaryBearsLLC:Upgrade-01-settings

Conversation

@BinaryBearsLLC

@BinaryBearsLLC BinaryBearsLLC commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Part 1 of 6. This PR is ready for review; the following five remain drafts until their dependencies land.

Review and merge order: #169 → #170 → #171 → #172 → #173 → #174.

What does this PR do?

Adds a Settings destination to the sidebar, bringing appearance, language and Full Disk Access controls into one place.

  • Keeps the existing cleaning, schedule and safety preferences available.
  • Shares the layout with the standard macOS Settings window and presents permission dialogs in the correct window.

Testing

  • Tested on macOS Ventura 13.6 (22G120, Apple Silicon VM).
  • Host XCTest suite and universal arm64/x86_64 build on macOS 26.6.2.

102 XCTest tests passed on macOS 26.6.2 (Apple Silicon); universal arm64/x86_64 build succeeded. Tested on macOS Ventura 13.6 (22G120, Apple Silicon VM). GUI checks passed for sidebar/standard Settings, theme persistence and the denied-access permission guide. Full Disk Access grant/revoke was additionally verified on the final cumulative build.

Screenshots

Sidebar settings dark

Standard settings window

@momenbasel

Copy link
Copy Markdown
Owner

Landed in #184 as 0ebcc7b with your authorship, plus 79b9727 on top, which hides the in-content header when the page is shown in the standard Settings window so Cmd-comma does not say Settings twice. Verified: the restart hint moved into AppState so it survives section switches, keyboard navigation reaches the new section, and the sheet routing is correct by reading. Ships in 3.1.0; thanks.

@momenbasel momenbasel closed this Oct 8, 2026
0x00kh pushed a commit to 0x00kh/PureMac that referenced this pull request Oct 8, 2026
…ndow

momenbasel#169 by @BinaryBearsLLC renders the same SettingsView on the sidebar page
and in the Settings scene, so the Cmd+, window titled "Settings" repeated
"Settings" and the tagline as a 26 pt header right under its title bar.

The standalone window now opens on the tab picker. The sidebar page keeps
its header, and the version and build it carried stay reachable on the
Updates tab.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants