Repository navigation
[1/6] Add a dedicated Settings page - #169
Closed
BinaryBearsLLC wants to merge 1 commit into
Closed
BinaryBearsLLC wants to merge 1 commit into
BinaryBearsLLC wants to merge 1 commit into
Conversation
This was referenced Sep 16, 2026
Owner
|
Landed in #184 as 0ebcc7b with your authorship, plus 79b9727 on top, which hides the in-content header when the page is shown in the standard Settings window so Cmd-comma does not say Settings twice. Verified: the restart hint moved into AppState so it survives section switches, keyboard navigation reaches the new section, and the sheet routing is correct by reading. Ships in 3.1.0; thanks. |
0x00kh
pushed a commit
to 0x00kh/PureMac
that referenced
this pull request
Oct 8, 2026
…ndow momenbasel#169 by @BinaryBearsLLC renders the same SettingsView on the sidebar page and in the Settings scene, so the Cmd+, window titled "Settings" repeated "Settings" and the tagline as a 26 pt header right under its title bar. The standalone window now opens on the tab picker. The sidebar page keeps its header, and the version and build it carried stay reachable on the Updates tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of 6. This PR is ready for review; the following five remain drafts until their dependencies land.
Review and merge order: #169 → #170 → #171 → #172 → #173 → #174.
What does this PR do?
Adds a Settings destination to the sidebar, bringing appearance, language and Full Disk Access controls into one place.
Testing
102 XCTest tests passed on macOS 26.6.2 (Apple Silicon); universal arm64/x86_64 build succeeded. Tested on macOS Ventura 13.6 (22G120, Apple Silicon VM). GUI checks passed for sidebar/standard Settings, theme persistence and the denied-access permission guide. Full Disk Access grant/revoke was additionally verified on the final cumulative build.
Screenshots