Add guard-clause to clearDirty method#16404
Merged
opengeek merged 3 commits intomodxcms:3.xfrom May 23, 2023
Merged
Conversation
sebastian-marinescu
requested review from
Mark-H and
opengeek
as code owners
smg6511
reviewed
Feb 27, 2023
smg6511
approved these changes
Mar 2, 2023
Collaborator
smg6511
left a comment
smg6511
left a comment
There was a problem hiding this comment.
For the simple purpose of avoiding error, this does the job. Supporting checkboxgroup/radiogroup types may need to be revisited, as it's hard to know whether the clearDirty method is taking effect on those component types without setting up a special CMP for the purpose of testing.
Ibochkarev
approved these changes
May 15, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## 3.x #16404 +/- ##
============================================
- Coverage 21.73% 17.90% -3.84%
+ Complexity 10483 10480 -3
============================================
Files 561 561
Lines 31614 39240 +7626
============================================
+ Hits 6872 7024 +152
- Misses 24742 32216 +7474 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Very nice! 🦾 |
opengeek
added a commit
that referenced
this pull request
Mar 22, 2024
### What does it do? This makes sure the JS doesn't throw an error in the case that the items-object is an array, just like in #16404 for 3.x ### Why is it needed? When using ExtJS to create components of the xtype: 'radiogroup' to be used in CMPs inside a form, this function gets called and tries to iterate over it's items array with a method that doesn't exist. This PR isn't changing the way forms or the clearDirty-method are handled, it just assures no error is thrown when using radiogroup-components. ### Related issue(s)/PR(s) Resolves modmore/ClientConfig#202 Resolves modmore/ClientConfig#176 Resolves modmore/ClientConfig#143 --------- Co-authored-by: Jason Coward <jason@opengeek.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
This makes sure the JS doesn't throw an error in the case that the items-object is an array.
Why is it needed?
When using ExtJS to create components of the
xtype: 'radiogroup'to be used in CMPs inside a form,this function gets called and tries to iterate over it's items array with a method that doesn't exist.
This PR isn't changing the way forms or the clearDirty-method are handled, it just assures no error is thrown when using radiogroup-components.
Related issue(s)/PR(s)
Resolves #12177
Resolves modmore/ClientConfig#202
Resolves modmore/ClientConfig#176
Resolves modmore/ClientConfig#143