fix(ui): cache complex Unicode cluster widths - #800
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR optimizes complex Unicode width measurement by segmenting composition-sensitive text once and caching exact multi-scalar cluster widths.
Confidence Score: 5/5The PR appears safe to merge with no concrete blocking or non-blocking defects identified. The bounded cache preserves exact cluster widths, enforces its intended entry and key-size limits, and the new segmented traversal remains equivalent to the existing Important Files Changed
Reviews (1): Last reviewed commit: "fix(ui): cache complex cluster widths" | Re-trigger Greptile |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
string-widthValidation
bun test src/ui/lib/ui-lib.test.tsbun run typecheckbun run lintbun run bench:terminal-width— checksum remains196000; complex-cluster hot path measured ~28.5× faster locallybun teststill has unrelated fresh-main failures in review-conformance/diff pairing plus Playwright test discovery.This PR description was generated by Pi using gpt-5.6-terra