feat(extensions): expose current selected line - #779
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThe PR adds API v7 support for immutable
Confidence Score: 5/5The PR appears safe to merge, with the new selection snapshot contract consistently implemented, documented, and tested. Runtime API versioning derives from the updated constant, production snapshots always include the new field, and ownership checks prevent stale cursor addresses from being exposed against a different file or hunk. Important Files Changed
Sequence DiagramsequenceDiagram
participant Key as Terminal key event
participant App as App command dispatch
participant Review as Review controller
participant Builder as Selection snapshot builder
participant Ext as Extension command
Key->>App: Invoke extension command
App->>Review: getSelection()
Review-->>App: normalized file and hunk
App->>Review: getLineCursor()
Review-->>App: active cursor or null
App->>Builder: buildExtensionReviewSelection(...)
Builder-->>App: frozen file, hunkIndex, currentLine
App->>Ext: invoke with ctx.selection
Reviews (1): Last reviewed commit: "feat(extensions): expose the current sel..." | Re-trigger Greptile |
1 task
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ctx.selection.currentLinesnapshots for extension commandsValidation
bun run typecheckbun run lintbun run check:docsbun test src/ui/lib/extensionSelection.test.ts src/ui/fileViews/useFilePresentationController.test.tsx src/ui/AppHost.extension-sidebar.test.tsxbun run check:packremains blocked before consumer validation by the repository's missingsrc/assets/zig/tree-sitter-zig.wasm; the full suite also has an unrelatedsrc/core/diffFile.test.tspairing failure and missing@axe-core/playwrightwebsite dependency.This PR description was generated by Pi using gpt-5.6-terra