-
Notifications
You must be signed in to change notification settings - Fork 98
feat: add Kitty follow integration #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
reVrost
wants to merge
1
commit into
modem-dev:main
Choose a base branch
from
reVrost:codex/kitty-follow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| """Kitty watcher that asks marked Hunk sessions to follow the active pane.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import os | ||
| import shutil | ||
| import subprocess | ||
| import time | ||
| from typing import Any | ||
|
|
||
|
|
||
| _last_sync_at_by_window: dict[int, float] = {} | ||
|
|
||
|
|
||
| def _debounce_seconds() -> float: | ||
| raw_value = os.environ.get("HUNK_KITTY_FOLLOW_DEBOUNCE_MS", "250") | ||
| try: | ||
| return max(0, int(raw_value)) / 1000 | ||
| except ValueError: | ||
| return 0.25 | ||
|
|
||
|
|
||
| def _hunk_binary() -> str | None: | ||
| return os.environ.get("HUNK_BIN") or shutil.which("hunk") | ||
|
|
||
|
|
||
| def _sync(window_id: int) -> None: | ||
| hunk = _hunk_binary() | ||
| if not hunk: | ||
| return | ||
|
|
||
| args = [hunk, "kitty", "sync", "--window-id", str(window_id)] | ||
| listen_on = os.environ.get("KITTY_LISTEN_ON") | ||
| if listen_on: | ||
| args.extend(["--to", listen_on]) | ||
|
|
||
| subprocess.Popen( | ||
| args, | ||
| stdin=subprocess.DEVNULL, | ||
| stdout=subprocess.DEVNULL, | ||
| stderr=subprocess.DEVNULL, | ||
| close_fds=True, | ||
| ) | ||
|
|
||
|
|
||
| def on_focus_change(boss: Any, window: Any, data: dict[str, Any]) -> None: | ||
| if not data.get("focused"): | ||
| return | ||
|
|
||
| window_id = int(window.id) | ||
| now = time.monotonic() | ||
| last_sync_at = _last_sync_at_by_window.get(window_id, 0) | ||
| if now - last_sync_at < _debounce_seconds(): | ||
| return | ||
|
|
||
| _last_sync_at_by_window[window_id] = now | ||
| _sync(window_id) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,6 +29,7 @@ | |
| "files": [ | ||
| "bin", | ||
| "dist/npm", | ||
| "kitty", | ||
| "skills", | ||
| "README.md", | ||
| "LICENSE" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_last_sync_at_by_window_last_sync_at_by_windowis a module-level dict that accumulates one entry per uniquewindow.idbut never evicts stale entries. Kitty recycles integer window IDs within a session, so the actual risk of unbounded growth is low — but there is noon_closehook to clean up closed windows. Over a long Kitty session with many windows, this will hold a non-trivial number of stale float entries. Registering anon_closecallback (def on_close(boss, window): _last_sync_at_by_window.pop(int(window.id), None)) would keep the dict bounded.Prompt To Fix With AI