Streamable HTTP - resume streams on disconnect#332
Merged
Merged
Conversation
jspahrsummers
requested changes
Apr 14, 2025
Member
jspahrsummers
left a comment
jspahrsummers
left a comment
There was a problem hiding this comment.
Haven't had a chance to look at the examples or tests in depth yet, but pointed out some things I think we need to change before getting this in.
| * Maximum backoff time between reconnection attempts in milliseconds. | ||
| * Default is 30000 (30 seconds). | ||
| */ | ||
| maxReconnectionDelay: number; |
Member
There was a problem hiding this comment.
There's probably a library on npm that can do some of this out of the box.
Contributor
Author
There was a problem hiding this comment.
the logic is minimal, can come back to this later if it's non-blocking?
jspahrsummers
approved these changes
Apr 15, 2025
Member
jspahrsummers
left a comment
jspahrsummers
left a comment
There was a problem hiding this comment.
I don't have bandwidth to review the tests and examples, but the main implementation looks good to me now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per spec servers might support resumability and redelivery.
Introducing resumability and re-delivery of events for disconnection within the same client.
StreamableHTTPReconnectionOptionsinterface for custom reconnection and backoffstart-notification-stream'tool which starts notifications for that can be used for testingFollow ups: