Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/hot-panthers-matter.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@modelcontextprotocol/examples-server": patch
"@modelcontextprotocol/test-integration": patch
---

Fix in-memory event replay to preserve the stored event stream id when resuming task notifications.
10 changes: 3 additions & 7 deletions examples/server/src/inMemoryEventStore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,10 @@ export class InMemoryEventStore implements EventStore {
}

/**
* Extracts the stream ID from an event ID
* Looks up the stream ID for an event ID
*/
private getStreamIdFromEventId(eventId: string): string {
const parts = eventId.split('_');
return parts.length > 0 ? parts[0]! : '';
return this.events.get(eventId)?.streamId ?? '';
}

/**
Expand Down Expand Up @@ -53,10 +52,7 @@ export class InMemoryEventStore implements EventStore {

let foundLastEvent = false;

// Sort events by eventId for chronological ordering
const sortedEvents = [...this.events.entries()].toSorted((a, b) => a[0].localeCompare(b[0]));

for (const [eventId, { streamId: eventStreamId, message }] of sortedEvents) {
for (const [eventId, { streamId: eventStreamId, message }] of this.events) {
// Only include events from the same stream
if (eventStreamId !== streamId) {
continue;
Expand Down
31 changes: 28 additions & 3 deletions test/integration/test/taskResumability.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,11 @@ class InMemoryEventStore implements EventStore {
{ send }: { send: (eventId: string, message: JSONRPCMessage) => Promise<void> }
): Promise<string> {
if (!lastEventId || !this.events.has(lastEventId)) return '';
const streamId = lastEventId.split('_')[0] ?? '';
const streamId = this.events.get(lastEventId)?.streamId ?? '';
if (!streamId) return '';

let found = false;
const sorted = [...this.events.entries()].toSorted((a, b) => a[0].localeCompare(b[0]));
for (const [eventId, { streamId: sid, message }] of sorted) {
for (const [eventId, { streamId: sid, message }] of this.events) {
if (sid !== streamId) continue;
if (eventId === lastEventId) {
found = true;
Expand Down Expand Up @@ -141,6 +140,32 @@ describe('Zod v4', () => {
server.close();
});

it('replays events for stream IDs that contain underscores', async () => {
const firstMessage: JSONRPCMessage = {
jsonrpc: '2.0',
method: 'notifications/message',
params: { level: 'info', data: 'first' }
};
const secondMessage: JSONRPCMessage = {
jsonrpc: '2.0',
method: 'notifications/message',
params: { level: 'info', data: 'second' }
};

const firstEventId = await eventStore.storeEvent('_GET_stream', firstMessage);
const secondEventId = await eventStore.storeEvent('_GET_stream', secondMessage);
const replayed: Array<{ eventId: string; message: JSONRPCMessage }> = [];

const streamId = await eventStore.replayEventsAfter(firstEventId, {
send: async (eventId, message) => {
replayed.push({ eventId, message });
}
});

expect(streamId).toBe('_GET_stream');
expect(replayed).toEqual([{ eventId: secondEventId, message: secondMessage }]);
});

it('should store session ID when client connects', async () => {
// Create and connect a client
const client = new Client({
Expand Down
Loading