Skip to content

feat: mark boxed http body as sync (#285)#291

Merged
4t145 merged 1 commit into
modelcontextprotocol:mainfrom
4t145:use-sync-http-body
Jul 1, 2025
Merged

feat: mark boxed http body as sync (#285)#291
4t145 merged 1 commit into
modelcontextprotocol:mainfrom
4t145:use-sync-http-body

Conversation

@4t145
Copy link
Copy Markdown
Contributor

@4t145 4t145 commented Jun 30, 2025

make boxed http body in tower service sync.

Motivation and Context

resolve #285

The underlying http body types are already sync, so it would be better to mark them as sync.

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@github-actions github-actions Bot added T-core Core library changes T-transport Transport layer changes labels Jun 30, 2025
@4t145 4t145 requested a review from jokemanfire June 30, 2025 10:18
@4t145 4t145 merged commit 9ca20c6 into modelcontextprotocol:main Jul 1, 2025
11 checks passed
@github-actions github-actions Bot mentioned this pull request Jul 2, 2025
bug-ops pushed a commit to bug-ops/rust-sdk that referenced this pull request Jul 3, 2025
takumi-earth pushed a commit to earthlings-dev/rmcp that referenced this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-core Core library changes T-transport Transport layer changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return BoxedBody instead of UnsyncBoxBody

2 participants