mcp: fail connect when subscriptions listen is rejected - #1170
Open
jstar0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1169
When a v2026-07-28 streamable HTTP client installs notification handlers,
Client.Connectopenssubscriptions/listenafterserver/discover. If that listen call is rejected immediately, the client previously ignored the response and returned a session even though subscriptions were not active.This change lets the listen helper observe an immediate terminal response before detaching the long-lived call. Rejections now propagate through
Connect, and the partially opened session is closed on that connect error.Verification:
TestStreamableClientConnect_SubscriptionsListenError; the test fails onorigin/mainbecauseConnectsucceeds after the rejected listen requestgo test ./mcp -run 'TestStreamableClientConnect_SubscriptionsListenError|TestStreamableClientConnect_DiscoverSuccess|TestSubscriptionsListen_Streamable|TestResourceSubscriptions_Streamable|TestSubscriptionsListen_InMemory|TestResourceSubscriptions_InMemory' -count=1 -vpassedgo test ./...currently fails in this local environment only on the existing localhost protection cases whereevil.comresolves to0.0.0.0; the same two subtests fail on cleanorigin/main:TestSSELocalhostProtection/0.0.0.0_via_localhost_rejects_evil.comandTestStreamableLocalhostProtection/0.0.0.0_via_localhost_rejects_evil.com