mcp: close the session when Connect gets an unsupported protocol version - #1157
Closed
n0liu wants to merge 1 commit into
Closed
mcp: close the session when Connect gets an unsupported protocol version#1157n0liu wants to merge 1 commit into
n0liu wants to merge 1 commit into
Conversation
Client.Connect returned unsupportedProtocolVersionError without closing the ClientSession it had already built, and returned nil to the caller, so nothing could close it. The two adjacent error paths in the same function both call cs.Close(); this one now does too, so the reader goroutine and connection are not leaked on each failed attempt. Fixes modelcontextprotocol#1154
Contributor
|
Closing as duplicate of #1158 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1154.
Client.ConnectreturnedunsupportedProtocolVersionErrorwithout closing theClientSessionit had already built, and returnednilto the caller — so nothing outside the SDK could close it either. The two adjacent error paths in the same function both callcs.Close(); this one now does too.Without the fix, a client that retries against a server answering this way leaks a reader goroutine and its connection on every attempt, and on a stateful server the session is never deleted.
Added a test that fails Connect on an unsupported protocol version and asserts the session's connection is closed.
go test ./mcp/ -race,gofmt, andgo vetpass.