Skip to content

clients should check PKCE support #473

Closed

Description

@jba

The client auth implementation for clients should check that the auth server implements PKCE, as described in https://github.com/modelcontextprotocol/modelcontextprotocol/blob/main/docs/specification/draft/basic/authorization.mdx?plain=1#L350-L356.

Activity

  1. added
    help wantedContributions welcome from those familiar with codebase. Comment first to say you're working on it
    on Sep 30, 2025
  2. added this to the v1.1.0 milestone on Sep 30, 2025
  3. RyoKusnadi commented on Oct 1, 2025

    @RyoKusnadi
    Contributor

    Hi @jba, allow me to double confirming

    1. In auth_meta.go, Use GetAuthServerMeta and check using CodeChallengeMethodsSupported
    2. provide example in client_example_test.go

    let me know if i missed something.
    if already no issue, can assign this task to me? willing to raise the PR

  4. jba commented on Oct 6, 2025

    @jba
    ContributorAuthor

    Yes, CodeChallengeMethodsSupported must be a non-empty slice.

  5. added a commit that references this issue on Oct 14, 2025
  6. modified the milestones: v1.1.0, v1.2.0 on Oct 29, 2025
  7. removed this from the v1.2.0 milestone on Dec 9, 2025
  8. maciej-kisiel commented on Feb 3, 2026

    @maciej-kisiel
    Contributor

    This looks done (PR was merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

help wantedContributions welcome from those familiar with codebase. Comment first to say you're working on it

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions