Skip to content

Tests for "absolute" intrinsics #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adpaco merged 2 commits into from
Apr 13, 2022
Merged

Tests for "absolute" intrinsics #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
271037b
Tests for "absolute" intrinsics
adpaco Apr 11, 2022
d54361e
Merge branch 'main' into fabsfxx-audit
adpaco Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions tests/kani/Intrinsics/Math/fabsf32.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0 OR MIT

// Check that `fabsf32` returns the expected results: absolute value if argument
// is not NaN, otherwise NaN
#![feature(core_intrinsics)]

#[kani::proof]
fn test_abs_finite() {
let x: f32 = kani::any();
kani::assume(!x.is_nan());
let abs_x = unsafe { std::intrinsics::fabsf32(x) };
if x < 0.0 {
assert!(-x == abs_x);

@danielsn danielsn Apr 12, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I was surprised that this was == and not diff < epsilon but I see that floating point has an explicit sign bit https://en.wikipedia.org/wiki/Floating-point_arithmetic#IEEE_754:_floating_point_in_modern_computers

} else {
assert!(x == abs_x);
}
}

#[kani::proof]
fn test_abs_nan() {
let x: f32 = kani::any();
kani::assume(x.is_nan());
let abs_x = unsafe { std::intrinsics::fabsf32(x) };
assert!(abs_x.is_nan());
}
26 changes: 26 additions & 0 deletions tests/kani/Intrinsics/Math/fabsf64.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0 OR MIT

// Check that `fabsf64` returns the expected results: absolute value if argument
// is not NaN, otherwise NaN
#![feature(core_intrinsics)]

#[kani::proof]
fn test_abs_finite() {
let x: f64 = kani::any();
kani::assume(!x.is_nan());
let abs_x = unsafe { std::intrinsics::fabsf64(x) };
if x < 0.0 {
assert!(-x == abs_x);
} else {
assert!(x == abs_x);
}
}

#[kani::proof]
fn test_abs_nan() {
let x: f64 = kani::any();
kani::assume(x.is_nan());
let abs_x = unsafe { std::intrinsics::fabsf64(x) };
assert!(abs_x.is_nan());
}