Update Go to 1.17.4, replace io/ioutil with io, and update golang.org/x/sys

[errordeveloper]

No description provided.

[thaJeztah]

go: cannot find main module, but found vendor.conf

Looks like we need to set some GO111MODULE=off (or auto)

[codecov]

Codecov Report

Merging #3041 (a9a35e0) into master (6303310) will decrease coverage by 0.13%.
The diff coverage is 58.62%.

@@            Coverage Diff             @@
##           master    #3041      +/-   ##
==========================================
- Coverage   62.29%   62.15%   -0.14%     
==========================================
  Files         155      155              
  Lines       24533    24533              
==========================================
- Hits        15283    15249      -34     
- Misses       7656     7686      +30     
- Partials     1594     1598       +4     

[errordeveloper]

@thaJeztah @crazy-max CI is green!

[errordeveloper]

@thaJeztah I've rejigged the commits, PTAL :)

[errordeveloper]

Looks like there is flake:

time="2021-12-03T16:09:06Z" level=error msg="update failed" error="task ri6pdecw0ysjkwaqch8meac2y was already shut down when reached by updater (state: SHUTDOWN)" task.id=skjv8kyowuwfp620nr040gl0d
--- FAIL: TestUpdaterRollback (3.44s)
    --- FAIL: TestUpdaterRollback/pause/monitor_set/spec_version_unset (0.63s)
        update_test.go:272: service was updated
        update_test.go:337: 
            	Error Trace:	update_test.go:337
            	            				update_test.go:20
            	Error:      	Not equal: 
            	            	expected: "image2"
            	            	actual  : "image1"
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1 +1 @@
            	            	-image2
            	            	+image1
            	Test:       	TestUpdaterRollback/pause/monitor_set/spec_version_unset
FAIL
coverage: 84.9% of statements
FAIL	github.com/docker/swarmkit/manager/orchestrator/replicated	5.331s
FAIL

it's green after a re-run...

[thaJeztah]

Yes, I think it's a flaky test; I restarted CI earlier, and looks green again now 👍

[thaJeztah]

LGTM (not a maintainer though)

[thaJeztah]

@dperny @tonistiigi PTAL

[crazy-max]

@thaJeztah I think we need to also upgrade golang.org/x/sys no? moby/moby#42778

[thaJeztah]

Ah, yes, we should probably update that as well, although (IIRC), it only affects macOS, so not directly a huge concern in this repository (so I'd be OK with doing it separately)

[errordeveloper]

I tried this:

iff --git a/vendor.conf b/vendor.conf
index 994bd666..f377c49f 100644
--- a/vendor.conf
+++ b/vendor.conf
@@ -70,7 +70,7 @@ github.com/stretchr/testify                         ffdc059bfe9ce6a4e144ba849dbe
 go.etcd.io/bbolt                                    232d8fc87f50244f9c808f4745759e08a304c029 # v1.3.5
 golang.org/x/crypto                                 c1f2f97bffc9c53fc40a1a28a5b460094c0050d9
 golang.org/x/net                                    6772e930b67bb09bf22262c7378e7d2f67cf59d1
-golang.org/x/sys                                    d19ff857e887eacb631721f188c7d365c2331456
+golang.org/x/sys                                    63515b42dcdf9544f4e6a02fd7632793fde2f72d
 golang.org/x/text                                   23ae387dee1f90d29a23c0e87ee0b46038fbed0e # v0.3.3
 golang.org/x/time                                   555d28b269f0569763d25dbe1a237ae74c6bcc82
 

but vndr seems to revamp quite a few things... I suppose I can split the commits, but separate PR is probably needed, as this changes more than was regionally foreseen.

[thaJeztah]

Yes, let's do it separate to not overload this PR too much

[errordeveloper]

@thaJeztah I forgot --signoff, fixed now 🙈

[thaJeztah]

Hmm... looks like the DCO bot is not running in this repository; let me try if we can enable it

[thaJeztah]

oh, hm.. don't have access to the repository settings; perhaps @justincormack is able to help 🤔

[thaJeztah]

LGTM

(DCO messages look good)

[errordeveloper]

It turned out that accidental changes were somehow to do with my setup, so I'm adding another commit here to update golang.org/x/sys.

[errordeveloper]

It hits TestUpdaterRollback/pause/monitor_set/spec_version_unset flake again...

[errordeveloper]

cc @tonistiigi

[thaJeztah]

let me try close/reopen to kick CI, and to see if the DCO bot also gets kicked

[thaJeztah]

hm.. ok; it runs on #3042, but doesn't get triggered here 😞

[crazy-max]

@thaJeztah Looking at the events that bot listens to, pull_request.synchronize could do the trick. Implies a new commit has to be added to the HEAD ref.

[thaJeztah]

@thaJeztah Looking at the events that bot listens to, pull_request.synchronize could do the trick. Implies a new commit has to be added to the HEAD ref.

Hm.. yeah, that would explain it; perhaps that's part of the bug it previously had, where it got added to all existing pull request, but never got started. Wondering how to add the bot and make it run on all PRs (including existing ones) 🤔