go {build,test}: rm -i option - #2751
Merged
Merged
Conversation
Looks like it was used to get faster incremental builds. Nowdays (since Go 1.10) there is no need to use it, because go build cache is used [1]. This fixes `make binaries` on my system where golang is installed as read-only snap: > $ make binaries > 🐳 bin/swarmd > go build runtime/cgo: open /snap/go/2635/pkg/linux_amd64/runtime/cgo.a: read-only file system > direct.mk:100: recipe for target 'bin/swarmd' failed [1] https://groups.google.com/forum/#!msg/golang-dev/qfa3mHN4ZPA/X2UzjNV1BAAJ Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2751 +/- ##
==========================================
- Coverage 61.77% 61.74% -0.03%
==========================================
Files 134 134
Lines 21890 21890
==========================================
- Hits 13522 13517 -5
Misses 6911 6911
- Partials 1457 1462 +5 |
Contributor
Author
|
@anshulpundir @nishanttotla @thaJeztah PTAL Similar PR: moby/moby#37879 |
thaJeztah
approved these changes
Sep 25, 2018
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
LGTM
don't have permissions to merge though 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like it was used to get faster incremental builds.
Nowdays (since Go 1.10) there is no need to use it, because
go build cache is used [1].
This fixes
make binarieson my system where golang is installedas read-only snap:
[1] https://groups.google.com/forum/#!msg/golang-dev/qfa3mHN4ZPA/X2UzjNV1BAAJ