Update x/sys x/text vendoring - #2302
Merged
Merged
Conversation
Signed-off-by: Ali Yousuf <aly.yousuf7@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2302 +/- ##
==========================================
+ Coverage 61.06% 61.07% +<.01%
==========================================
Files 128 128
Lines 20550 20550
==========================================
+ Hits 12549 12550 +1
+ Misses 6630 6618 -12
- Partials 1371 1382 +11 |
alyyousuf7
changed the title
Contributor
|
#2299 hit this issue in CI too, I think |
Contributor
|
LGTM
Seems like a good idea as long as we are proactive about keeping the pinned version up to date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is complaining about inconsistent vendors:
https://circleci.com/gh/docker/swarmkit/7629
Signed-off-by: Ali Yousuf aly.yousuf7@gmail.com