vendor: github.com/docker/docker, docker/cli v28.0.1 - #5819
Merged
Merged
Conversation
thaJeztah
commented
Mar 6, 2025
thaJeztah
commented
Member
- follow- up to vendor: github.com/docker/docker, github.com/docker/cli v28.0.0-rc.1 #5602
- which got reverted in Revert "vendor: docker, docker/cli v28.0.0-rc.1" #5718
github-actions
Bot
added
the
area/dependencies
thaJeztah
changed the title
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
bump_docker_28.0.1
branch
from
March 6, 2025 22:27
ce72d3f to
9cea4ab
Compare
thaJeztah
marked this pull request as ready for review
March 7, 2025 16:52
crazy-max
approved these changes
Mar 7, 2025
tonistiigi
approved these changes
Mar 7, 2025
| // Display a warning if we're storing the users password (not a token). | ||
| // | ||
| // FIXME(thaJeztah): make output configurable instead of hardcoding to os.Stderr | ||
| _, _ = fmt.Fprintln(os.Stderr, fmt.Sprintf(unencryptedWarning, c.file.GetFilename())) |
Member
There was a problem hiding this comment.
Libraries should not print to stderr directly (this code is unused in buildkit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.